From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node Date: Wed, 21 Feb 2018 20:38:09 +0300 Message-ID: <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> <20180221100716.GF7203@w540> <20180221173106.vgyshbz3kkc4p3cu@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180221173106.vgyshbz3kkc4p3cu@verge.net.au> Content-Language: en-MW List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Simon Horman Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, jacopo mondi , magnus.damm@gmail.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, geert@linux-m68k.org, Jacopo Mondi , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 02/21/2018 08:31 PM, Simon Horman wrote: >>>>> Populate the ethernet@e6800000 device node to enable Ethernet interface >>>>> for R-Car M3-N (r8a77965) SoC. >>>>> >>>>> Signed-off-by: Jacopo Mondi >>>>> Reviewed-by: Geert Uytterhoeven >>>>> >>>>> --- >>>>> v1 -> v2: >>>>> - Replace ALWAYS_ON power area identifier with numeric constant >>>>> --- >>>>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++++++++++++++++++++++++++++++- >>>>> 1 file changed, 42 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>> index 55f05f7..c249895 100644 >>>>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >>>>> @@ -520,7 +520,48 @@ >>>>> }; >>>>> >>>>> avb: ethernet@e6800000 { >>>>> - /* placeholder */ >>>>> + compatible = "renesas,etheravb-r8a77965", >>>>> + "renesas,etheravb-rcar-gen3"; >>>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; >>>>> + interrupts = , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + , >>>>> + ; >>>>> + interrupt-names = "ch0", "ch1", "ch2", "ch3", >>>>> + "ch4", "ch5", "ch6", "ch7", >>>>> + "ch8", "ch9", "ch10", "ch11", >>>>> + "ch12", "ch13", "ch14", "ch15", >>>>> + "ch16", "ch17", "ch18", "ch19", >>>>> + "ch20", "ch21", "ch22", "ch23", >>>>> + "ch24"; >>>>> + clocks = <&cpg CPG_MOD 812>; >>>>> + power-domains = <&sysc 32>; >>>>> + resets = <&cpg 812>; >>>>> + phy-mode = "rgmii-txid"; >>>> >>>> Why not just "rgmii"? TX delay is a board specific detail, no? >>>> >>> I admit I took this one straight from r8a7796 dtsi. >>> Would you like to me resend and change this? >> >> Yes, unless Simon would fix it while merging... > > Can I confirm the desired change is s/rgmii-txid/rgmii/ ? Yes. > If so I can fix that up. Thank you! MBR, Sergei