From: "Heiko Stübner" <heiko@sntech.de>
To: Alexandru M Stan <amstan@chromium.org>,
Mike Turquette <mturquette@linaro.org>
Cc: Doug Anderson <dianders@chromium.org>,
addy ke <addy.ke@rock-chips.com>,
Sonny Rao <sonnyrao@chromium.org>,
Kever Yang <kever.yang@rock-chips.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
mark.rutland@arm.com, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, galak@codeaurora.org,
mark.yao@rock-chips.com
Subject: Re: [PATCH v3 0/2] Add support for the rockchip mmc clock phases using the framework
Date: Tue, 25 Nov 2014 10:35:06 +0100 [thread overview]
Message-ID: <3222595.cbGxNcWa4c@diego> (raw)
In-Reply-To: <1416344908-5975-1-git-send-email-amstan@chromium.org>
Am Dienstag, 18. November 2014, 13:08:26 schrieb Alexandru M Stan:
> For now all I have is the getter and setter for the phase, nothing that uses
> it (that is ready). You can test the getter like this:
> localhost ~ # cat /sys/kernel/debug/clk/clk_summary|grep sample -C 1
> sclk_sdio1 0 0 24000000
> 0 0 sdio1_sample 0 0 12000000
> 0 0 sdio1_drv 0 0 12000000
> 0 90 --
> sclk_sdmmc 1 1 297000000
> 0 0 sdmmc_sample 0 0 148500000 0 134
> sdmmc_drv 0 0 148500000 0 90 --
> sclk_sdio0 1 1 100000000
> 0 0 sdio0_sample 0 0 50000000 0 0
> sdio0_drv 0 0 50000000 0 90
> sclk_emmc 1 1 100000000 0 0
> emmc_sample 0 0 50000000 0 0
> emmc_drv 0 0 50000000 0 180
>
> Next thing that will come is some dts changes that will make use of these
> new clocks, and eventually mmc code will be changed to tune with these
> clocks.
As already said in v1, this looks nice to me, but I'll give Mike another day
or two to voice possible concerns.
Heiko
next prev parent reply other threads:[~2014-11-25 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 21:08 [PATCH v3 0/2] Add support for the rockchip mmc clock phases using the framework Alexandru M Stan
2014-11-18 21:08 ` [PATCH v3 1/2] clk: rockchip: add bindings for the mmc clocks Alexandru M Stan
2014-11-18 21:08 ` [PATCH v3 2/2] clk: rockchip: Add support for the mmc clock phases using the framework Alexandru M Stan
2014-11-25 9:35 ` Heiko Stübner [this message]
2014-11-25 17:14 ` [PATCH v3 0/2] Add support for the rockchip " Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3222595.cbGxNcWa4c@diego \
--to=heiko@sntech.de \
--cc=addy.ke@rock-chips.com \
--cc=amstan@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).