From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v6 2/6] [media] ad5820: DT new optional field enable-gpios Date: Tue, 02 Oct 2018 14:29:01 +0300 Message-ID: <3235299.fxFho4aFbc@avalon> References: <20181002111356.32298-1-ricardo.ribalda@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20181002111356.32298-1-ricardo.ribalda@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Ricardo Ribalda Delgado Cc: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Ricardo, Thank you for the patch. On Tuesday, 2 October 2018 14:13:56 EEST Ricardo Ribalda Delgado wrote: > Document new enable-gpio field. It can be used to disable the part > without turning down its regulator. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Ricardo Ribalda Delgado > Acked-by: Pavel Machek Reviewed-by: Laurent Pinchart > --- > Documentation/devicetree/bindings/media/i2c/ad5820.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt > b/Documentation/devicetree/bindings/media/i2c/ad5820.txt index > 5940ca11c021..db596e8eb0ba 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ad5820.txt > +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > @@ -8,6 +8,11 @@ Required Properties: > > - VANA-supply: supply of voltage for VANA pin > > +Optional properties: > + > + - enable-gpios : GPIO spec for the XSHUTDOWN pin. The XSHUTDOWN signal > is +active low, a high level on the pin enables the device. > + > Example: > > ad5820: coil@c { > @@ -15,5 +20,6 @@ Example: > reg = <0x0c>; > > VANA-supply = <&vaux4>; > + enable-gpios = <&msmgpio 26 GPIO_ACTIVE_HIGH>; > }; -- Regards, Laurent Pinchart