From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA6A12837D; Tue, 10 Sep 2024 15:41:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725982909; cv=none; b=ciUyLOo6q4c39bKneX1/9Yr29FwqdUlsPxJkqNkYfdTgkdmA3YxM0F5CzICmyPJRKxwpLX/0wLSNnv5m9ciQIk92l1mOpZrFJaD/WBzo0xGKaHG/hMF0HC3LI8AfJcHWEgIlG25faAIfgv03hZX2imUcvsOvt+iAMqLvgS6U88c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725982909; c=relaxed/simple; bh=0B1PDY3GCupfeN+oTs51y74KV9zPbrTetLqMbCSteDQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MINoeL83+kC2rXeCTiEb9cfmjigEI1yIEMBJ1GVHGAi+fhG0X3VW3dXyIVGsUMsBbo+PbTxykKYCjP9A4qQUGfc/gfnbwC81V0tZND7uup8EGidgF7xIY5YNHawrUjVxLunhNTfQzZYjX+y823t5VNMi7R31qf7FGFqDc5FpglQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=lhIA/mW+; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="lhIA/mW+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1725982904; bh=0B1PDY3GCupfeN+oTs51y74KV9zPbrTetLqMbCSteDQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lhIA/mW+1/LsTKLcV8vmZtyf+2GHfDpxcuGkMFlIj8n/D1VIiLjuWBdOftjlb7tRR VfhwtBXGmJnL/Wcp0zaFVUEGB4qvy91T1mR/7iMqqsa7rgLS8mMgk2fleXF9Z5z3DU SXY1XOd7GIDAmrLZuXGP96Wb59yw2OI+Md6Gr6b0SldkSGpQrQtIMPF6egTAgVNBDK eOOKAX34RIQ0HvSRGkhc5pZHb1rSqoLs2UDdJ+wcSXyiUVAVvP517sEpa6m9TctYLG n3THdc/CFDgm9ZcegfRA1HFjq3Du/fF0F25sIEpPRrYTQhlI8Ve7UV0BU+l3KfqrHj VAes9eaUbqMqw== Received: from [192.168.1.90] (unknown [188.27.55.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7DDC717E35CB; Tue, 10 Sep 2024 17:41:43 +0200 (CEST) Message-ID: <324b12ea-805a-499c-909d-3723f0bca7cb@collabora.com> Date: Tue, 10 Sep 2024 18:41:42 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] drm/rockchip: Add basic RK3588 HDMI output support To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Yao , Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com, Alexandre ARNOUD , Luis de Arquer , Algea Cao References: <20240906-b4-rk3588-bridge-upstream-v6-0-a3128fb103eb@collabora.com> <20240906-b4-rk3588-bridge-upstream-v6-3-a3128fb103eb@collabora.com> <1785617.Ii9rTq9gLj@diego> <1899262.u6TykanW85@diego> From: Cristian Ciocaltea Content-Language: en-US In-Reply-To: <1899262.u6TykanW85@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/10/24 6:21 PM, Heiko Stübner wrote: > Am Dienstag, 10. September 2024, 17:07:57 CEST schrieb Heiko Stübner: >> Am Freitag, 6. September 2024, 03:17:42 CEST schrieb Cristian Ciocaltea: >>> The RK3588 SoC family integrates the newer Synopsys DesignWare HDMI 2.1 >>> Quad-Pixel (QP) TX controller IP and a HDMI/eDP TX Combo PHY based on a >>> Samsung IP block. >>> >>> Add just the basic support for now, i.e. RGB output up to 4K@60Hz, >>> without audio, CEC or any of the HDMI 2.1 specific features. >>> >>> Co-developed-by: Algea Cao >>> Signed-off-by: Algea Cao >>> Tested-by: Heiko Stuebner >>> Signed-off-by: Cristian Ciocaltea >> >> I had switched from the v3 to this v6 in my playground-kernel today, >> with v3 I've never seen those, but now with v6 I have gotten multiple >> times: >> >> [ 805.730608] Internal error: synchronous external abort: 0000000096000010 [#1] PREEMPT SMP >> [ 805.739764] Modules linked in: snd_soc_simple_card crct10dif_ce snd_soc_simple_card_utils panthor drm_gpuvm drm_exec fuse >> [ 805.752031] CPU: 3 UID: 0 PID: 775 Comm: Xorg Not tainted 6.11.0-rc7-00099-g459302f1f908-dirty #934 >> [ 805.762143] Hardware name: Theobroma Systems RK3588-Q7 SoM on Haikou devkit (DT) >> [ 805.770407] pstate: 204000c9 (nzCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--) >> [ 805.778186] pc : regmap_mmio_read32le+0x8/0x20 >> [ 805.783155] lr : regmap_mmio_read+0x44/0x70 >> [ 805.787828] sp : ffff80008293b830 >> [ 805.791516] x29: ffff80008293b830 x28: ffff80008293bce8 x27: ffff0001f20ab080 >> [ 805.799495] x26: ffff800081139500 x25: 0000000000000000 x24: 0000000000000010 >> [ 805.807472] x23: 0000000000000000 x22: ffff0001f5a4b400 x21: ffff80008293b8c4 >> [ 805.815450] x20: 0000000000000968 x19: ffff0001f5a27a80 x18: 0000000000000070 >> [ 805.823428] x17: 0002441400000005 x16: 000004650441043c x15: 0438000008980804 >> [ 805.831406] x14: 07d8089807800780 x13: 0438000008980804 x12: ffff800081133630 >> [ 805.839384] x11: 0002441400000005 x10: 000004650441043c x9 : ffff800081a59000 >> [ 805.847361] x8 : 07d8089807800780 x7 : 0000000000000000 x6 : ffff0001f5b453c0 >> [ 805.855339] x5 : ffff800080750dc0 x4 : 0000000000000968 x3 : 0000000000000968 >> [ 805.863316] x2 : ffff800080751520 x1 : 0000000000000968 x0 : ffff800083b20968 >> [ 805.871294] Call trace: >> [ 805.874012] regmap_mmio_read32le+0x8/0x20 >> [ 805.878588] _regmap_bus_reg_read+0x6c/0xac >> [ 805.883262] _regmap_read+0x60/0xd8 >> [ 805.887159] _regmap_update_bits+0xf4/0x140 >> [ 805.891832] regmap_update_bits_base+0x64/0xa0 >> [ 805.896797] dw_hdmi_qp_bridge_atomic_enable+0x134/0x220 >> [ 805.902734] drm_atomic_bridge_chain_enable+0x54/0xc8 >> [ 805.908380] drm_atomic_helper_commit_modeset_enables+0x194/0x280 >> [ 805.915190] drm_atomic_helper_commit_tail_rpm+0x50/0xa0 >> [ 805.921125] commit_tail+0xa0/0x1a0 >> [ 805.925021] drm_atomic_helper_commit+0x17c/0x1b0 >> [ 805.930276] drm_atomic_commit+0xb8/0x100 >> [ 805.934754] drm_atomic_connector_commit_dpms+0xe0/0x110 >> [ 805.940690] drm_mode_obj_set_property_ioctl+0x1c0/0x420 >> [ 805.946626] drm_connector_property_set_ioctl+0x3c/0x68 >> [ 805.952465] drm_ioctl_kernel+0xc0/0x130 >> [ 805.956846] drm_ioctl+0x214/0x4a0 >> [ 805.960643] __arm64_sys_ioctl+0xac/0xf8 >> [ 805.965025] invoke_syscall+0x48/0x104 >> [ 805.969214] el0_svc_common.constprop.0+0x40/0xe0 >> [ 805.974470] do_el0_svc+0x1c/0x28 >> [ 805.978171] el0_svc+0x34/0xe0 >> [ 805.981582] el0t_64_sync_handler+0x120/0x12c >> [ 805.986449] el0t_64_sync+0x190/0x194 >> [ 805.990540] Code: d503201f d503201f f9400000 8b214000 (b9400000) >> >> I guess that might be some clocking issue? > > Forgot to add, this happens when the display has blanked and then is > supposed to unblank again. Hmm, I've never encountered this while testing with my v6.11-rc1 based tree. What is your current kernel base? Did you change it while switching from v3 to v6? I'll rebase my tree onto latest linux-next and see if I can reproduce. Thanks for reporting this! Regards, Cristian