From: Arnd Bergmann <arnd@arndb.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
mbizon@freebox.fr, jogo@openwrt.org, gregkh@linuxfoundation.org,
mark.rutland@arm.com, gregory.0xf0@gmail.com
Subject: Re: [PATCH tty-next v2 4/4] Documentation: devicetree: add bindings documentation for bcm63xx-uart
Date: Fri, 21 Feb 2014 13:49:05 +0100 [thread overview]
Message-ID: <3250738.VGSO94B75K@wuerfel> (raw)
In-Reply-To: <1392920154-3642-5-git-send-email-f.fainelli@gmail.com>
Two more comments:
On Thursday 20 February 2014 10:15:54 Florian Fainelli wrote:
> +- clock-names: should contain "periph" for the functional clock
I think we should really start standardizing on the clock names more.
We don't have any uart that calls its functional clock "periph" so
far.
How about naming it "fclk" or "uart"?
I'd actually prefer making it an anonymous clock, but I know that
will just trigger comments about what might happen if it turns
out we need more than one clock for a future version of this device.
> +Example:
> +
> +serial0: uart@600 {
> + compatible = "brcm,bcm6345-uart";
> + reg = <0x600 0x1b>;
> + interrupts = <GIC_SPI 32 0>;
> + clocks = <&periph_clk>;
> + clock-names = "periph";
> +};
The device name for a uart is "serial" by convention, not "uart",
so better make this serial@600.
Arnd
next prev parent reply other threads:[~2014-02-21 12:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 18:15 [PATCH tty-next v2 0/4] Device Tree probing for bcm63xx_uart Florian Fainelli
2014-02-20 18:15 ` [PATCH tty-next v2 1/4] tty: serial: bcm63xx_uart: include linux/io.h Florian Fainelli
2014-02-20 18:15 ` [PATCH tty-next v2 2/4] tty: serial: bcm63xx_uart: define UART_REG_SIZE constant Florian Fainelli
2014-02-20 18:15 ` [PATCH tty-next v2 3/4] tty: serial: bcm63xx_uart: add support for DT probing Florian Fainelli
2014-02-20 18:15 ` [PATCH tty-next v2 4/4] Documentation: devicetree: add bindings documentation for bcm63xx-uart Florian Fainelli
2014-02-21 12:08 ` Mark Rutland
2014-02-21 12:49 ` Arnd Bergmann [this message]
2014-02-21 13:49 ` Mark Rutland
2014-02-21 14:48 ` Jonas Gorski
2014-02-21 14:59 ` Arnd Bergmann
2014-02-21 15:18 ` Jonas Gorski
2014-02-21 15:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3250738.VGSO94B75K@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.0xf0@gmail.com \
--cc=jogo@openwrt.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox