From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 609D4C433EF for ; Fri, 18 Feb 2022 12:52:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235363AbiBRMxG (ORCPT ); Fri, 18 Feb 2022 07:53:06 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235326AbiBRMxA (ORCPT ); Fri, 18 Feb 2022 07:53:00 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FA862B31BE; Fri, 18 Feb 2022 04:52:37 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id BB9231F46910 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1645188755; bh=NFXnrBefp/J/5Gr6/ZFXtadzPDXIH73osHYu1ilvrI4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=T9yMUZQcsLCccMxiGNCW3eVpLugQ11wDo+tAUv6bZ4gs0UHcel9POp4VISzkzON0L dJOk2+ORvjNaNvEiQiUvatcRJMplsu2pVnHLcqoT356YzirB7LamiXv3jT+qinx5DE qnxBS6Z/bjpZ2pxHiHoMteRWww1ZTAof+bjqGBAEr6I/kI2GLQasjNrlykQYeRYnCi E6U2DxZQMjVhhP9eg7UsspUKqozH93Kp8d4kgqH/gNsrjSy8RyMDgcC2UO8vo0JrmU jolB5zRsIxdgFAIueGs6+FR3sUfVsiVfpF0jNWS9MODY2wYYsPOJs6R58Iw81W/iaY v+rmihOeKnUxw== Message-ID: <325255a5-4ece-bf3d-a994-d19689b49c2d@collabora.com> Date: Fri, 18 Feb 2022 13:52:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v5 26/34] iommu/mediatek: Remove mtk_iommu.h Content-Language: en-US To: Yong Wu , Joerg Roedel , Rob Herring , Matthias Brugger , Will Deacon Cc: Robin Murphy , Krzysztof Kozlowski , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Hsin-Yi Wang , youlin.pei@mediatek.com, anan.sun@mediatek.com, xueqi.zhang@mediatek.com, yen-chang.chen@mediatek.com, mingyuan.ma@mediatek.com, yf.wang@mediatek.com, libo.kang@mediatek.com, chengci.xu@mediatek.com References: <20220217113453.13658-1-yong.wu@mediatek.com> <20220217113453.13658-27-yong.wu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220217113453.13658-27-yong.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 17/02/22 12:34, Yong Wu ha scritto: > Currently there is only compare_of/release_of/a suspend structure in the > header file. I think it is no need to keep a header file only for these. > Move these into the c file and rm this header file. > > I think there should be a common helper for compare_of and release_of. > There is many copy in drm, it should be another topic. > > Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno > --- > drivers/iommu/mtk_iommu.c | 25 ++++++++++++++++++++- > drivers/iommu/mtk_iommu.h | 42 ------------------------------------ > drivers/iommu/mtk_iommu_v1.c | 21 +++++++++++++++--- > 3 files changed, 42 insertions(+), 46 deletions(-) > delete mode 100644 drivers/iommu/mtk_iommu.h >