From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Date: Mon, 17 Jul 2017 05:28:20 +0300 Message-ID: <3257165.sao50mFgxX@avalon> References: <1500101920-24039-1-git-send-email-jacob-chen@iotwrt.com> <2238838.k7NpPUxaC0@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jacob Chen Cc: "open list:ARM/Rockchip SoC..." , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Mauro Carvalho Chehab , Linux Media Mailing List , laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, Hans Verkuil , s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Tomasz Figa , Nicolas Dufresne List-Id: devicetree@vger.kernel.org Hi Jacob, On Sunday 16 Jul 2017 12:23:02 Jacob Chen wrote: > 2017-07-15 17:16 GMT+08:00 Laurent Pinchart: > > On Saturday 15 Jul 2017 14:58:39 Jacob Chen wrote: > >> Signed-off-by: Jacob Chen > >> --- > >> > >> arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++ > >> arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 4 ++++ > >> arch/arm/boot/dts/rk3288-firefly.dtsi | 4 ++++ > >> arch/arm/boot/dts/rk3288-miqi.dts | 4 ++++ > >> arch/arm/boot/dts/rk3288-popmetal.dts | 4 ++++ > >> arch/arm/boot/dts/rk3288-tinker.dts | 4 ++++ > > > > Some boards are missing from this list (Fennec, Phycore, ...) What > > criteria have you used to decide on which ones to enable the RGA ? That > > should be explained in the commit message. > > Ok. > > I just enable the boards i have tested, because i can't make sure it > won't break the other board because of clocks or power-domains. Given the clocks and power domains shouldn't be board-specific, would it make sense to try and get the change tested on the remaining boards ? You could then enable the device in the SoC .dtsi file, which would be much simpler. > >> 6 files changed, 24 insertions(+) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html