From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1160C00528 for ; Mon, 7 Aug 2023 05:34:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230256AbjHGFeT (ORCPT ); Mon, 7 Aug 2023 01:34:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbjHGFeR (ORCPT ); Mon, 7 Aug 2023 01:34:17 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E44AE10F0; Sun, 6 Aug 2023 22:34:15 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3775Y8nl046085; Mon, 7 Aug 2023 00:34:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691386448; bh=gK+1tom2NTDuvtabUDe1zttKQIA+z1CtJea2uDrn4y8=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=DSH/iaVT5r59hjn7Ul0KTbeHqTSY7vvphLwhLO6gZVyKTfnlvSzjwCiLTs2piACoE z2qd1wze4MJD22seyQ0sCF5lhPVAx+NDx/idi4yTq5EzdpIlxH2gmDvyxO1O0yVVMc 3t+fqoLxSpDz54o9l50ibKedUMVDT+vFDLE/69z8= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3775Y8nt002568 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 7 Aug 2023 00:34:08 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 7 Aug 2023 00:34:08 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 7 Aug 2023 00:34:08 -0500 Received: from [172.24.227.68] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3775Y4Za118614; Mon, 7 Aug 2023 00:34:05 -0500 Message-ID: <325df39c-8c98-1719-8460-7d9ff7bca549@ti.com> Date: Mon, 7 Aug 2023 11:04:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 08/13] arm64: dts: ti: k3-j721e: Enable GPIO nodes at the board level Content-Language: en-US To: Andrew Davis , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , CC: , References: <20230802205309.257392-1-afd@ti.com> <20230802205309.257392-9-afd@ti.com> From: Dhruva Gole In-Reply-To: <20230802205309.257392-9-afd@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/08/23 02:23, Andrew Davis wrote: > GPIO nodes defined in the top-level J721e SoC dtsi files are incomplete > and may not be functional unless they are extended with pinmux and > device information. > > Disable the GPIO nodes in the dtsi files and only enable the ones that > are actually pinned out on a given board. > > Signed-off-by: Andrew Davis > --- > .../boot/dts/ti/k3-j721e-beagleboneai64.dts | 42 ++++--------------- > .../dts/ti/k3-j721e-common-proc-board.dts | 35 ++++------------ > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 8 ++++ > .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 + > arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 31 +++----------- > 5 files changed, 31 insertions(+), 87 deletions(-) > Reviewed-by: Dhruva Gole > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts > index 0b89977351c98..99536765939d9 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts > @@ -647,52 +647,24 @@ eeprom@50 { > }; > }; > > -&main_gpio2 { > - /* Unused */ > - status = "disabled"; > -}; > - > -&main_gpio3 { > - /* Unused */ > - status = "disabled"; > -}; > - > -&main_gpio4 { > - /* Unused */ > - status = "disabled"; > -}; > - > -&main_gpio5 { > - /* Unused */ > - status = "disabled"; > -}; > - > -&main_gpio6 { > - /* Unused */ > - status = "disabled"; > -}; > - > -&main_gpio7 { > - /* Unused */ > - status = "disabled"; > -}; > - > &wkup_gpio0 { > + status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&mcu_adc0_pins_default>, <&mcu_adc1_pins_default>, > <&mikro_bus_pins_default>; > }; > > -&wkup_gpio1 { > - /* Unused */ > - status = "disabled"; > -}; > - > &main_gpio0 { > + status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&csi1_gpio_pins_default>, <&csi0_gpio_pins_default>; > }; > > +&main_gpio1 { > + status = "okay"; > + /* default pins */ > +}; > + > &usb_serdes_mux { > idle-states = <1>, <1>; /* USB0 to SERDES3, USB1 to SERDES2 */ > }; > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > index e9b84d2c64b26..2fd940893eb5f 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > @@ -469,37 +469,20 @@ &main_uart4 { > pinctrl-0 = <&main_uart4_pins_default>; > }; > > -&main_gpio2 { > - status = "disabled"; > -}; > - > -&main_gpio3 { > - status = "disabled"; > -}; > - > -&main_gpio4 { > - status = "disabled"; > -}; > - > -&main_gpio5 { > - status = "disabled"; > -}; > - > -&main_gpio6 { > - status = "disabled"; > -}; > - > -&main_gpio7 { > - status = "disabled"; > -}; > - > &wkup_gpio0 { > + status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&wkup_gpio_pins_default>; > }; > > -&wkup_gpio1 { > - status = "disabled"; > +&main_gpio0 { > + status = "okay"; > + /* default pins */ > +}; > + > +&main_gpio1 { > + status = "okay"; > + /* default pins */ > }; > > &main_sdhci0 { > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > index 0ca31186b9b74..7f663d9280b57 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > @@ -1339,6 +1339,7 @@ main_gpio0: gpio@600000 { > power-domains = <&k3_pds 105 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 105 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > main_gpio1: gpio@601000 { > @@ -1355,6 +1356,7 @@ main_gpio1: gpio@601000 { > power-domains = <&k3_pds 106 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 106 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > main_gpio2: gpio@610000 { > @@ -1372,6 +1374,7 @@ main_gpio2: gpio@610000 { > power-domains = <&k3_pds 107 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 107 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > main_gpio3: gpio@611000 { > @@ -1388,6 +1391,7 @@ main_gpio3: gpio@611000 { > power-domains = <&k3_pds 108 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 108 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > main_gpio4: gpio@620000 { > @@ -1405,6 +1409,7 @@ main_gpio4: gpio@620000 { > power-domains = <&k3_pds 109 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 109 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > main_gpio5: gpio@621000 { > @@ -1421,6 +1426,7 @@ main_gpio5: gpio@621000 { > power-domains = <&k3_pds 110 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 110 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > main_gpio6: gpio@630000 { > @@ -1438,6 +1444,7 @@ main_gpio6: gpio@630000 { > power-domains = <&k3_pds 111 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 111 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > main_gpio7: gpio@631000 { > @@ -1454,6 +1461,7 @@ main_gpio7: gpio@631000 { > power-domains = <&k3_pds 112 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 112 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > main_sdhci0: mmc@4f80000 { > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > index 0c01bdd9656f1..4d107eee9b341 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > @@ -281,6 +281,7 @@ wkup_gpio0: gpio@42110000 { > power-domains = <&k3_pds 113 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 113 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > wkup_gpio1: gpio@42100000 { > @@ -297,6 +298,7 @@ wkup_gpio1: gpio@42100000 { > power-domains = <&k3_pds 114 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 114 0>; > clock-names = "gpio"; > + status = "disabled"; > }; > > mcu_i2c0: i2c@40b00000 { > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > index 4cd5346f2dd59..dfb6af60482e7 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts > @@ -731,41 +731,20 @@ &main_i2c5 { > }; > > &main_gpio0 { > + status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&rpi_header_gpio0_pins_default>; > }; > > &main_gpio1 { > + status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&rpi_header_gpio1_pins_default>; > }; > > -&main_gpio2 { > - status = "disabled"; > -}; > - > -&main_gpio3 { > - status = "disabled"; > -}; > - > -&main_gpio4 { > - status = "disabled"; > -}; > - > -&main_gpio5 { > - status = "disabled"; > -}; > - > -&main_gpio6 { > - status = "disabled"; > -}; > - > -&main_gpio7 { > - status = "disabled"; > -}; > - > -&wkup_gpio1 { > - status = "disabled"; > +&wkup_gpio0 { > + status = "okay"; > + /* default pins */ > }; > > &usb_serdes_mux { -- Thanks and Regards, Dhruva Gole