Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

From: Archit Taneja <architt@codeaurora.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Cyprian Wronka <cwronka@cadence.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Simon Hatliff <hatliff@cadence.com>,
	dri-devel@lists.freedesktop.org,
	Richard Sproul <sproul@cadence.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alan Douglas <adouglas@cadence.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Kumar Gala <galak@codeaurora.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Neil Webb <neilw@cadence.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings
Date: Wed, 14 Jun 2017 09:14:46 +0530	[thread overview]
Message-ID: <327ae11b-8b10-1b80-625a-3d207435b5c1@codeaurora.org> (raw)
In-Reply-To: <9ca829e6-4696-7c3a-aed3-6a2af3161557@ti.com>

On 06/06/2017 06:28 PM, Tomi Valkeinen wrote:
> On 06/06/17 15:48, Boris Brezillon wrote:
> 
>> Okay. Thanks for the clarification. Can you confirm that this version
>> is correct?
>>
>>   	dsi@xxx {
>>   		#address-cells = <1>;
>>   		#size-cells = <0>;
>>   
>>   		ports {
>>   			#address-cells = <1>;
>>   			#size-cells = <0>;
>> 			dpi_in: port@0 {
>>   				reg = <0>;
>>   				#address-cells = <1>;
>>   				#size-cells = <0>;
>>   
>>   				endpoint@0 {
>>   					remote-endpoint = <&dpi_out>;
>>   				};
>>   			};
>>   
>>   			dsi_out: port@1 {
>>   				reg = <1>;
>> 				#address-cells = <1>;
>>   				#size-cells = <0>;
>>   
>>   				dsi_out_vc0: endpoint@0 {
>> 					reg = <0>;
>>   					remote-endpoint = <&dsi_panel0_in>;
>> 				};
>>
>>   				dsi_out_vc1: endpoint@1 {
>> 					reg = <1>;
>>   					remote-endpoint = <&dsi_panel1_in>;
>>   				};
>>   			};
>>   		};
>>   
>>   		panel@0 {
>>   			compatible = "...";
>>   			reg = <0>;
>>   			#address-cells = <1>;
>>   			#size-cells = <0>;
>>   
>>   			port@0 {
>>   				#address-cells = <1>;
>>   		                #size-cells = <0>;
>>   				reg = <0>;
>>   
>>   				dsi_panel0_in: endpoint@0 {
>> 					reg = <0>;
>>   					remote-endpoint = <&dsi_out_vc0>;
>>   				};
>>   			};
>>   		};
>>   
>>   		panel@1 {
>>   			compatible = "...";
>>   			reg = <1>;
>>   			#address-cells = <1>;
>>   			#size-cells = <0>;
>>   
>>   			port@0 {
>>   				#address-cells = <1>;
>>   		                #size-cells = <0>;
>>   				reg = <0>;
>>   
>>   				dsi_panel1_in: endpoint@0 {
>> 					reg = <0>;
>>   					remote-endpoint = <&dsi_out_vc1>;
>>   				};
>>   			};
>>   		};
>>   	};
>>
> 
> Looks correct to me. I think it can be a bit shorter though:
> 
> - You don't need #address-cells and #size-cells for all. I think those
> are inherited from the parent.
> - If there's just one port and one endpoint, you can leave the 'reg'
> out, as it's considered to be 0 by default.
> 
> So for the panel, you can have just:
> 
> port {
> 	dsi_panel1_in: endpoint {
> 		remote-endpoint = <&dsi_out_vc1>;
> 	};
> };

Looks good to me too.

Thanks,
Archit

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel