From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 34B0BC433F5
	for <linux-devicetree@archiver.kernel.org>; Tue, 22 Feb 2022 23:11:20 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234401AbiBVXLo (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Tue, 22 Feb 2022 18:11:44 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36848 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231131AbiBVXLo (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Tue, 22 Feb 2022 18:11:44 -0500
Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03F4E8BF20;
        Tue, 22 Feb 2022 15:11:16 -0800 (PST)
Received: from [185.156.123.69] (helo=phil.localnet)
        by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
        (Exim 4.92)
        (envelope-from <heiko@sntech.de>)
        id 1nMeJN-0006se-UC; Wed, 23 Feb 2022 00:11:13 +0100
From:   Heiko Stuebner <heiko@sntech.de>
To:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        Michael Riesch <michael.riesch@wolfvision.net>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Liang Chen <cl@rock-chips.com>, frank-w@public-files.de
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: enable rk809 audio codec on the rk3568 evb1
Date:   Wed, 23 Feb 2022 00:11:12 +0100
Message-ID: <3287619.yDqD7nnjd0@phil>
In-Reply-To: <20220222175004.1308990-2-michael.riesch@wolfvision.net>
References: <20220222175004.1308990-1-michael.riesch@wolfvision.net> <20220222175004.1308990-2-michael.riesch@wolfvision.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

Hi,

Am Dienstag, 22. Februar 2022, 18:50:04 CET schrieb Michael Riesch:
> Enable the Rockchip RK809 audio codec on the Rockchip RK3568
> EVB1. This requires the VCCIO_ACODEC voltage regulator to be set
> to always on.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

[...]

> @@ -282,6 +301,7 @@ regulator-state-mem {
>  
>  			vccio_acodec: LDO_REG4 {
>  				regulator-name = "vccio_acodec";
> +				regulator-always-on;

As this seems to supply the codec (in the rk809?) shouldn't the
sound part model that relationship and handle regulators
instead of requiring an arbitary regulator to be always on?


Heiko

>  				regulator-min-microvolt = <3300000>;
>  				regulator-max-microvolt = <3300000>;
>  
> @@ -366,6 +386,10 @@ regulator-state-mem {
>  				};
>  			};
>  		};
> +
> +		codec {
> +			mic-in-differential;
> +		};
>  	};
>  };
>  
> @@ -386,6 +410,11 @@ touchscreen0: goodix@14 {
>  	};
>  };
>  
> +&i2s1_8ch {
> +	rockchip,trcm-sync-tx-only;
> +	status = "okay";
> +};
> +
>  &mdio0 {
>  	rgmii_phy0: ethernet-phy@0 {
>  		compatible = "ethernet-phy-ieee802.3-c22";
>