From: Matthias Brugger <matthias.bgg@gmail.com>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Wenbin Mei <wenbin.mei@mediatek.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
ryder.lee@kernel.org, wenst@chromium.org,
chunfeng.yun@mediatek.com
Subject: Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Date: Tue, 29 Mar 2022 16:27:43 +0200 [thread overview]
Message-ID: <32931f81-5615-8156-4c67-bb4260488185@gmail.com> (raw)
In-Reply-To: <20220329114540.17140-3-tinghan.shen@mediatek.com>
On 29/03/2022 13:45, Tinghan Shen wrote:
> Add optional host top register base for the reg binding description.
>
Is this based a on a new version of the IP? Shall we make the second reg
mandatory for the new HW? If I remember correctly the reg needs to be restored
after power save event. So I suppose mmc won't work if that's not done. So
optional wouldn't be the right approach.
Can you please clarify if that's the case.
Thanks,
Matthias
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 7032f7adf3ca..6d41bcec900f 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -40,7 +40,8 @@ properties:
> - const: mediatek,mt8183-mmc
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> clocks:
> description:
next prev parent reply other threads:[~2022-03-29 14:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 11:45 [PATCH v12 0/3] Add basic SoC support for mediatek mt8195 Tinghan Shen
2022-03-29 11:45 ` [PATCH v12 1/3] dt-bindings: mmc: mtk-sd: fix yamllint error Tinghan Shen
2022-03-29 12:47 ` AngeloGioacchino Del Regno
2022-03-30 2:55 ` Tinghan Shen
2022-03-29 11:45 ` [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems Tinghan Shen
2022-03-29 12:43 ` AngeloGioacchino Del Regno
2022-03-29 19:10 ` Rob Herring
2022-03-30 8:20 ` AngeloGioacchino Del Regno
2022-03-29 14:27 ` Matthias Brugger [this message]
2022-03-30 7:33 ` Tinghan Shen
2022-03-29 20:38 ` Rob Herring
2022-03-30 7:25 ` Tinghan Shen
2022-03-29 11:45 ` [PATCH v12 3/3] arm64: dts: Add mediatek SoC mt8195 and evaluation board Tinghan Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32931f81-5615-8156-4c67-bb4260488185@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@kernel.org \
--cc=tinghan.shen@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).