devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andrei Simion <andrei.simion@microchip.com>,
	claudiu.beznea@tuxon.dev, nicolas.ferre@microchip.com,
	alexandre.belloni@bootlin.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, peda@axentia.se
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	cristian.birsan@microchip.com
Subject: Re: [PATCH 1/5] ARM: dts: microchip: Clean up spacing and indentation
Date: Wed, 14 Aug 2024 15:20:09 +0200	[thread overview]
Message-ID: <3294e2d3-5142-4d7f-89d3-35528f26066e@kernel.org> (raw)
In-Reply-To: <20240814122633.198562-2-andrei.simion@microchip.com>

On 14/08/2024 14:26, Andrei Simion wrote:
> Checkpatch.pl reports some ERRORS related
> to coding style (spacing and indentation).
> So clean up : checkpatch.pl --fix-inplace

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Please be specific what are you changing.


> 
> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
> ---
> Split the bloated patch into small patches on topics
> based on comments:
> https://lore.kernel.org/linux-arm-kernel/89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev/
> ---
>  arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts  | 2 +-
>  arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts | 8 ++++----
>  arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts      | 8 ++++----
>  arch/arm/boot/dts/microchip/at91sam9263ek.dts         | 2 +-
>  4 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
> index 04cb7bee937d..1279dfb38300 100644
> --- a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
> +++ b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
> @@ -7,7 +7,7 @@
>   *			HCE Engineering
>   *
>   * Derived from at91sam9g35ek.dts by:
> - * 	Copyright (C) 2012 Atmel,
> + *	Copyright (C) 2012 Atmel,

Not sure what you are fixing here, but unnecessary tab was here before
and still exists...

>   *      2012 Nicolas Ferre <nicolas.ferre@atmel.com>
>   */
>  

Best regards,
Krzysztof


  reply	other threads:[~2024-08-14 13:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 12:26 [PATCH 0/5] Cosmetic Work for ARM/Microchip (AT91) Andrei Simion
2024-08-14 12:26 ` [PATCH 1/5] ARM: dts: microchip: Clean up spacing and indentation Andrei Simion
2024-08-14 13:20   ` Krzysztof Kozlowski [this message]
2024-08-14 13:32     ` Andrei.Simion
2024-08-14 13:57       ` Krzysztof Kozlowski
2024-08-14 14:20         ` Andrei.Simion
2024-08-14 12:26 ` [PATCH 2/5] ARM: dts: microchip: Rename the eeprom nodename Andrei Simion
2024-08-14 12:26 ` [PATCH 3/5] ARM: dts: microchip: Rename the pmic node Andrei Simion
2024-08-14 13:20   ` Krzysztof Kozlowski
2024-08-14 13:58     ` Krzysztof Kozlowski
2024-08-14 12:26 ` [PATCH 4/5] ARM: dts: microchip: Rename the usb node Andrei Simion
2024-08-14 13:22   ` Krzysztof Kozlowski
2024-09-05 13:51     ` Andrei.Simion
2024-09-05 13:55       ` Krzysztof Kozlowski
2024-08-14 12:26 ` [PATCH 5/5] ARM: dts: microchip: Rename LED sub nodes name Andrei Simion
2024-08-14 13:23   ` Krzysztof Kozlowski
2024-08-15  7:57   ` Alexander Dahl
2024-08-16  8:52     ` Andrei.Simion
2024-08-16  9:06       ` Alexander Dahl
2024-08-20  6:32         ` Andrei.Simion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3294e2d3-5142-4d7f-89d3-35528f26066e@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrei.simion@microchip.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=cristian.birsan@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=peda@axentia.se \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).