From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8797DC433EF for ; Wed, 9 Feb 2022 16:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236851AbiBIQ2Z (ORCPT ); Wed, 9 Feb 2022 11:28:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236980AbiBIQ2X (ORCPT ); Wed, 9 Feb 2022 11:28:23 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6D9CC05CB9B; Wed, 9 Feb 2022 08:28:18 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHpp8-0002r1-Gg; Wed, 09 Feb 2022 17:28:06 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring , Michael Riesch Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Peter Geis , Nicolas Frattaroli , Sascha Hauer , Ezequiel Garcia , linux-kernel@vger.kernel.org, Liang Chen , devicetree@vger.kernel.org, David Airlie , Alex Bee , Rob Herring Subject: Re: [PATCH v5 1/5] dt-bindings: gpu: mali-bifrost: describe clocks for the rk356x gpu Date: Wed, 09 Feb 2022 17:28:05 +0100 Message-ID: <3297396.uCXnvZdJcx@diego> In-Reply-To: <01b78d95-fdf3-060a-831d-dae2abbc7109@wolfvision.net> References: <20220209085110.3588035-1-michael.riesch@wolfvision.net> <1644420908.380944.391811.nullmailer@robh.at.kernel.org> <01b78d95-fdf3-060a-831d-dae2abbc7109@wolfvision.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Michael, Am Mittwoch, 9. Februar 2022, 16:46:28 CET schrieb Michael Riesch: > Hi Rob, > > On 2/9/22 16:35, Rob Herring wrote: > > On Wed, 09 Feb 2022 09:51:06 +0100, Michael Riesch wrote: > >> From: Alex Bee > >> > >> The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. > >> Reflect this in the SoC specific part of the binding. > >> > >> Signed-off-by: Alex Bee > >> [move the changes to the SoC section] > >> Signed-off-by: Michael Riesch > >> --- > >> .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > ./Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml:173:12: [warning] wrong indentation: expected 12 but found 11 (indentation) > > D'oh! Sorry for the stupid mistake, I found that yamllint was indeed > missing. > > Lines 173 and 174 need an extra space. In the case that a v6 is required > I'll fix this. But of course I wouldn't say no if this could be fixed > when the patch is applied :-) My guess is, Rob's bot filters out the easy wrongs, so I'm not sure if he actually looks at these in person. So doing a v6 might actually be better for a Review :-) Heiko > > > > dtschema/dtc warnings/errors: > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/patch/1590238 > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > >