From: Markus Elfring <Markus.Elfring@web.de>
To: Weidong Wang <wangweidong.a@awinic.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Ben Yi" <yijiangtao@awinic.com>,
"Binbin Zhou" <zhoubinbin@loongson.cn>,
"Conor Dooley" <conor+dt@kernel.org>,
"Igor Prusov" <ivprusov@salutedevices.com>,
"Jack Yu" <jack.yu@realtek.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>, "Nuno Sá" <nuno.sa@analog.com>,
"Paul Handrigan" <paulha@opensource.cirrus.com>,
"Prasad Kumpatla" <quic_pkumpatl@quicinc.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Rob Herring" <robh@kernel.org>, "Takashi Iwai" <tiwai@suse.com>
Subject: Re: [PATCH 2/2] ASoC: codecs: Add aw88166 amplifier driver
Date: Tue, 25 Feb 2025 14:09:39 +0100 [thread overview]
Message-ID: <32992dc7-15a1-4ca5-a5a1-e7e26ce74fbc@web.de> (raw)
In-Reply-To: <20250221102623.369435-3-wangweidong.a@awinic.com>
…
> The driver is for amplifiers aw88166 of Awinic Technology
…
You may occasionally put more than 57 characters into text lines
of such a change description.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc4#n94
…
> +++ b/sound/soc/codecs/aw88166.c
> @@ -0,0 +1,1937 @@
…
> +static int aw_dev_dsp_read(struct aw_device *aw_dev,
+ unsigned short dsp_addr, unsigned int *dsp_data, unsigned char data_type)
> +{
…
> + mutex_lock(&aw_dev->dsp_lock);
> + switch (data_type) {
> + case AW88166_DSP_16_DATA:
…
> + mutex_unlock(&aw_dev->dsp_lock);
> +
> + return ret;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&aw_dev->dsp_lock);”?
https://elixir.bootlin.com/linux/v6.14-rc4/source/include/linux/mutex.h#L201
Regards,
Markus
next prev parent reply other threads:[~2025-02-25 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 10:26 [PATCH V1 0/2] ASoC: codecs: Add aw88166 amplifier driver wangweidong.a
2025-02-21 10:26 ` [PATCH V1 1/2] ASoC: dt-bindings: Add schema for "awinic,aw88166" wangweidong.a
2025-02-23 11:46 ` Krzysztof Kozlowski
2025-02-21 10:26 ` [PATCH V1 2/2] ASoC: codecs: Add aw88166 amplifier driver wangweidong.a
2025-02-23 11:46 ` Krzysztof Kozlowski
2025-02-25 7:42 ` wangweidong.a
2025-02-25 8:17 ` Krzysztof Kozlowski
2025-02-25 13:09 ` Markus Elfring [this message]
2025-02-25 13:20 ` [PATCH " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32992dc7-15a1-4ca5-a5a1-e7e26ce74fbc@web.de \
--to=markus.elfring@web.de \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivprusov@salutedevices.com \
--cc=jack.yu@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=paulha@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=quic_pkumpatl@quicinc.com \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=yijiangtao@awinic.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox