Re: [PATCH v6 3/9] iio: adc: ad_sigma_delta: add disable_one callback

["Nuno Sá" <noname.nuno@gmail.com>]

On Fri, 2024-06-07 at 12:29 +0300, Ceclan, Dumitru wrote:
> On 07/06/2024 12:02, Nuno Sá wrote:
> > On Thu, 2024-06-06 at 19:07 +0300, Dumitru Ceclan via B4 Relay wrote:
> > > From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > > 
> > > Sigma delta ADCs with a sequencer need to disable the previously enabled
> > > channel when reading using ad_sigma_delta_single_conversion(). This was
> > > done manually in drivers for devices with sequencers.
> > > 
> > > This patch implements handling of single channel disabling after a
> > > single conversion.
> > > 
> > > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > > ---
> > 
> > You could have this done in separate patches... Oh well, this is simple
> > enough
> > that I don't care much.
> > 
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > 
> 
> Separate patches would break driver functionality then fix it.
> The drivers would not probe as disable_one() callback is missing.
> 
> This would have been alright?
> 

No, it's not... I mean, you could also only enforce the disable_one() presence
after updating all users but I agree this is simple enough to go in one patch.

- Nuno Sá