* [PATCH 0/3] Add support for GPMC NAND
@ 2023-09-13 11:47 Nitin Yadav
2023-09-13 11:47 ` [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support Nitin Yadav
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Nitin Yadav @ 2023-09-13 11:47 UTC (permalink / raw)
To: nm, vigneshr, rogerq
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
catalin.marinas, will, linux-arm-kernel, devicetree, linux-kernel
This series adds support for GPMC NAND on AM62x LP SK
board.
Nitin Yadav (3):
arm64: dts: ti: Add GPMC NAND support
arm64: dts: ti: Add GPMC NAND overlay
arm64: defconfig: Enable GPMC NAND support
arch/arm64/boot/dts/ti/Makefile | 1 +
.../arm64/boot/dts/ti/k3-am62-lp-sk-nand.dtso | 119 ++++++++++++++++++
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 +++++
arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 +
arch/arm64/configs/defconfig | 3 +
5 files changed, 154 insertions(+)
create mode 100644 arch/arm64/boot/dts/ti/k3-am62-lp-sk-nand.dtso
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support
2023-09-13 11:47 [PATCH 0/3] Add support for GPMC NAND Nitin Yadav
@ 2023-09-13 11:47 ` Nitin Yadav
2023-09-14 6:27 ` Krzysztof Kozlowski
2023-09-15 11:16 ` Roger Quadros
2023-09-13 11:47 ` [PATCH 2/3] arm64: dts: ti: Add GPMC NAND overlay Nitin Yadav
2023-09-13 11:47 ` [PATCH 3/3] arm64: defconfig: Enable GPMC NAND support Nitin Yadav
2 siblings, 2 replies; 10+ messages in thread
From: Nitin Yadav @ 2023-09-13 11:47 UTC (permalink / raw)
To: nm, vigneshr, rogerq
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
catalin.marinas, will, linux-arm-kernel, devicetree, linux-kernel
Add support for AM62Q NAND card: X8 NAND EXPANSION
BOARD card (PROC143E1) for AM62x LP SK board.
Signed-off-by: Nitin Yadav <n-yadav@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++
2 files changed, 31 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index 284b90c94da8..e93e79d8083f 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};
+ gpmc0: memory-controller@3b000000 {
+ status = "disabled";
+ compatible = "ti,am64-gpmc";
+ power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 80 0>;
+ clock-names = "fck";
+ reg = <0x00 0x03b000000 0x00 0x400>,
+ <0x00 0x050000000 0x00 0x8000000>;
+ reg-names = "cfg", "data";
+ interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
+ gpmc,num-cs = <3>;
+ gpmc,num-waitpins = <2>;
+ #address-cells = <2>;
+ #size-cells = <1>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ elm0: ecc@25010000 {
+ status = "disabled";
+ compatible = "ti,am3352-elm";
+ reg = <0x00 0x25010000 0x00 0x2000>;
+ interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&k3_pds 54 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 54 0>;
+ clock-names = "fck";
+ };
};
diff --git a/arch/arm64/boot/dts/ti/k3-am62.dtsi b/arch/arm64/boot/dts/ti/k3-am62.dtsi
index 11f14eef2d44..f7d8aad0a016 100644
--- a/arch/arm64/boot/dts/ti/k3-am62.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62.dtsi
@@ -76,6 +76,8 @@ cbass_main: bus@f0000 {
<0x00 0x70000000 0x00 0x70000000 0x00 0x00010000>, /* OCSRAM */
<0x01 0x00000000 0x01 0x00000000 0x00 0x00310000>, /* A53 PERIPHBASE */
<0x05 0x00000000 0x05 0x00000000 0x01 0x00000000>, /* FSS0 DAT3 */
+ <0x00 0x3b000000 0x00 0x3b000000 0x00 0x00000400>, /* GPMC0_CFG */
+ <0x00 0x50000000 0x00 0x50000000 0x00 0x08000000>, /* GPMC0 DATA */
/* MCU Domain Range */
<0x00 0x04000000 0x00 0x04000000 0x00 0x01ff1400>,
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/3] arm64: dts: ti: Add GPMC NAND overlay
2023-09-13 11:47 [PATCH 0/3] Add support for GPMC NAND Nitin Yadav
2023-09-13 11:47 ` [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support Nitin Yadav
@ 2023-09-13 11:47 ` Nitin Yadav
2023-09-13 11:47 ` [PATCH 3/3] arm64: defconfig: Enable GPMC NAND support Nitin Yadav
2 siblings, 0 replies; 10+ messages in thread
From: Nitin Yadav @ 2023-09-13 11:47 UTC (permalink / raw)
To: nm, vigneshr, rogerq
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
catalin.marinas, will, linux-arm-kernel, devicetree, linux-kernel
Introduce k3-am62-lp-sk-nand.dtso overlay file to support
the addon card. NAND has partitions for different boot
components as below:
0x000000000000-0x000000200000 : "NAND.tiboot3
0x000000200000-0x000000400000 : "NAND.tispl
0x000000400000-0x000000600000 : "NAND.tiboot3.backup
0x000000600000-0x000000a00000 : "NAND.u-boot
0x000000a00000-0x000000a40000 : "NAND.u-boot-env
0x000000a40000-0x000000a80000 : "NAND.u-boot-env.backup
0x000000a80000-0x000040000000 : "NAND.file-system
Disable mcasp1 node in DT to avoid pinmux conflict.
Update Makefile to include k3-am62-lp-sk-nand.dtso.
Signed-off-by: Nitin Yadav <n-yadav@ti.com>
---
arch/arm64/boot/dts/ti/Makefile | 1 +
.../arm64/boot/dts/ti/k3-am62-lp-sk-nand.dtso | 119 ++++++++++++++++++
2 files changed, 120 insertions(+)
create mode 100644 arch/arm64/boot/dts/ti/k3-am62-lp-sk-nand.dtso
diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
index e7b8e2e7f083..40159abf058e 100644
--- a/arch/arm64/boot/dts/ti/Makefile
+++ b/arch/arm64/boot/dts/ti/Makefile
@@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-dahlia.dtb
dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-dev.dtb
dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-yavia.dtb
dtb-$(CONFIG_ARCH_K3) += k3-am62-lp-sk.dtb
+dtb-$(CONFIG_ARCH_K3) += k3-am62-lp-sk-nand.dtbo
dtb-$(CONFIG_ARCH_K3) += k3-am62x-sk-hdmi-audio.dtbo
# Boards with AM62Ax SoC
diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk-nand.dtso b/arch/arm64/boot/dts/ti/k3-am62-lp-sk-nand.dtso
new file mode 100644
index 000000000000..0f4e26db534b
--- /dev/null
+++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk-nand.dtso
@@ -0,0 +1,119 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2022-2023 Texas Instruments Incorporated - https://www.ti.com/
+ */
+
+/dts-v1/;
+/plugin/;
+
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+#include "k3-pinctrl.h"
+
+&mcasp1 {
+ status = "disabled";
+};
+
+&main_pmx0 {
+ gpmc0_pins_default: gpmc0-pins-default {
+ pinctrl-single,pins = <
+ AM62X_IOPAD(0x003c, PIN_INPUT, 0) /* (M25) GPMC0_AD0 */
+ AM62X_IOPAD(0x0040, PIN_INPUT, 0) /* (N23) GPMC0_AD1 */
+ AM62X_IOPAD(0x0044, PIN_INPUT, 0) /* (N24) GPMC0_AD2 */
+ AM62X_IOPAD(0x0048, PIN_INPUT, 0) /* (N25) GPMC0_AD3 */
+ AM62X_IOPAD(0x004c, PIN_INPUT, 0) /* (P24) GPMC0_AD4 */
+ AM62X_IOPAD(0x0050, PIN_INPUT, 0) /* (P22) GPMC0_AD5 */
+ AM62X_IOPAD(0x0054, PIN_INPUT, 0) /* (P21) GPMC0_AD6 */
+ AM62X_IOPAD(0x0058, PIN_INPUT, 0) /* (R23) GPMC0_AD7 */
+ AM62X_IOPAD(0x0084, PIN_OUTPUT, 0) /* (L23) GPMC0_ADVn_ALE */
+ AM62X_IOPAD(0x0088, PIN_OUTPUT, 0) /* (L24) GPMC0_OEn_REn */
+ AM62X_IOPAD(0x008c, PIN_OUTPUT, 0) /* (L25) GPMC0_WEn */
+ AM62X_IOPAD(0x0090, PIN_OUTPUT, 0) /* (M24) GPMC0_BE0n_CLE */
+ AM62X_IOPAD(0x00a8, PIN_OUTPUT, 0) /* (M21) GPMC0_CSn0 */
+ AM62X_IOPAD(0x0098, PIN_INPUT, 0) /* (U23) GPMC0_WAIT0 */
+ >;
+ };
+};
+
+&gpmc0 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&gpmc0_pins_default>;
+ ranges = <0 0 0x00 0x51000000 0x01000000>; /* CS0 space. Min partition = 16MB */
+ #address-cells = <2>;
+ #size-cells = <1>;
+
+ nand0_0: nand@0,0 {
+ compatible = "ti,am64-nand";
+ reg = <0 0 64>; /* device IO registers */
+ interrupt-parent = <&gpmc0>;
+ interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
+ <1 IRQ_TYPE_NONE>; /* termcount */
+ rb-gpios = <&gpmc0 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */
+ ti,nand-xfer-type = "prefetch-polled";
+ ti,nand-ecc-opt = "bch8"; /* BCH8: Bootrom limitation */
+ ti,elm-id = <&elm0>;
+ nand-bus-width = <8>;
+ gpmc,device-width = <1>;
+ gpmc,sync-clk-ps = <0>;
+ gpmc,cs-on-ns = <0>;
+ gpmc,cs-rd-off-ns = <40>;
+ gpmc,cs-wr-off-ns = <40>;
+ gpmc,adv-on-ns = <0>;
+ gpmc,adv-rd-off-ns = <25>;
+ gpmc,adv-wr-off-ns = <25>;
+ gpmc,we-on-ns = <0>;
+ gpmc,we-off-ns = <20>;
+ gpmc,oe-on-ns = <3>;
+ gpmc,oe-off-ns = <30>;
+ gpmc,access-ns = <30>;
+ gpmc,rd-cycle-ns = <40>;
+ gpmc,wr-cycle-ns = <40>;
+ gpmc,bus-turnaround-ns = <0>;
+ gpmc,cycle2cycle-delay-ns = <0>;
+ gpmc,clk-activation-ns = <0>;
+ gpmc,wr-access-ns = <40>;
+ gpmc,wr-data-mux-bus-ns = <0>;
+
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "NAND.tiboot3";
+ reg = <0x00000000 0x00200000>; /* 2M */
+ };
+ partition@200000 {
+ label = "NAND.tispl";
+ reg = <0x00200000 0x00200000>; /* 2M */
+ };
+ partition@400000 {
+ label = "NAND.tiboot3.backup"; /* 2M */
+ reg = <0x00400000 0x00200000>; /* BootROM looks at 4M */
+ };
+ partition@600000 {
+ label = "NAND.u-boot";
+ reg = <0x00600000 0x00400000>; /* 4M */
+ };
+ partition@a00000 {
+ label = "NAND.u-boot-env";
+ reg = <0x00a00000 0x00040000>; /* 256K */
+ };
+ partition@a40000 {
+ label = "NAND.u-boot-env.backup";
+ reg = <0x00a40000 0x00040000>; /* 256K */
+ };
+ partition@a80000 {
+ label = "NAND.file-system";
+ reg = <0x00a80000 0x3f580000>;
+ };
+ };
+ };
+};
+
+&elm0{
+ status = "okay";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm64: defconfig: Enable GPMC NAND support
2023-09-13 11:47 [PATCH 0/3] Add support for GPMC NAND Nitin Yadav
2023-09-13 11:47 ` [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support Nitin Yadav
2023-09-13 11:47 ` [PATCH 2/3] arm64: dts: ti: Add GPMC NAND overlay Nitin Yadav
@ 2023-09-13 11:47 ` Nitin Yadav
2 siblings, 0 replies; 10+ messages in thread
From: Nitin Yadav @ 2023-09-13 11:47 UTC (permalink / raw)
To: nm, vigneshr, rogerq
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
catalin.marinas, will, linux-arm-kernel, devicetree, linux-kernel
Enable config required to support GPMC NAND on
AM62x LP SK abd AM64x SKEVM.
Signed-off-by: Nitin Yadav <n-yadav@ti.com>
---
arch/arm64/configs/defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5315789f4868..a3ace041e9ff 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -270,6 +270,8 @@ CONFIG_MTD_DATAFLASH=y
CONFIG_MTD_SST25L=y
CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_NAND_DENALI_DT=y
+CONFIG_MTD_NAND_OMAP2=m
+CONFIG_MTD_NAND_OMAP_BCH=y
CONFIG_MTD_NAND_MARVELL=y
CONFIG_MTD_NAND_BRCMNAND=m
CONFIG_MTD_NAND_FSL_IFC=y
@@ -1351,6 +1353,7 @@ CONFIG_ARM_MEDIATEK_CCI_DEVFREQ=m
CONFIG_EXTCON_PTN5150=m
CONFIG_EXTCON_USB_GPIO=y
CONFIG_EXTCON_USBC_CROS_EC=y
+CONFIG_OMAP_GPMC=m
CONFIG_RENESAS_RPCIF=m
CONFIG_IIO=y
CONFIG_EXYNOS_ADC=y
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support
2023-09-13 11:47 ` [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support Nitin Yadav
@ 2023-09-14 6:27 ` Krzysztof Kozlowski
2023-09-14 9:26 ` Nitin Yadav
2023-09-15 11:16 ` Roger Quadros
1 sibling, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-14 6:27 UTC (permalink / raw)
To: Nitin Yadav, nm, vigneshr, rogerq
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
catalin.marinas, will, linux-arm-kernel, devicetree, linux-kernel
On 13/09/2023 13:47, Nitin Yadav wrote:
> Add support for AM62Q NAND card: X8 NAND EXPANSION
> BOARD card (PROC143E1) for AM62x LP SK board.
>
> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
> arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++
> 2 files changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 284b90c94da8..e93e79d8083f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> status = "disabled";
> };
> + gpmc0: memory-controller@3b000000 {
> + status = "disabled";
status is never first in DTSI. Really, where did you see such code?
> + compatible = "ti,am64-gpmc";
> + power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
First is compatible, second is reg/reg-names/ranges.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support
2023-09-14 6:27 ` Krzysztof Kozlowski
@ 2023-09-14 9:26 ` Nitin Yadav
2023-09-14 16:04 ` Nishanth Menon
0 siblings, 1 reply; 10+ messages in thread
From: Nitin Yadav @ 2023-09-14 9:26 UTC (permalink / raw)
To: Krzysztof Kozlowski, nm, vigneshr, rogerq
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
catalin.marinas, will, linux-arm-kernel, devicetree, linux-kernel
Hi Krzysztof,
On 14/09/23 11:57, Krzysztof Kozlowski wrote:
> On 13/09/2023 13:47, Nitin Yadav wrote:
>> Add support for AM62Q NAND card: X8 NAND EXPANSION
>> BOARD card (PROC143E1) for AM62x LP SK board.
>>
>> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
>> arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++
>> 2 files changed, 31 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> index 284b90c94da8..e93e79d8083f 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
>> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
>> status = "disabled";
>> };
>> + gpmc0: memory-controller@3b000000 {
>> + status = "disabled";
>
> status is never first in DTSI. Really, where did you see such code?
Thank for pointing out, Will send a revised version.
>
>> + compatible = "ti,am64-gpmc";
>> + power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
>
> First is compatible, second is reg/reg-names/ranges.
>
>
> Best regards,
> Krzysztof
>
--
Regards,
Nitin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support
2023-09-14 9:26 ` Nitin Yadav
@ 2023-09-14 16:04 ` Nishanth Menon
2023-09-15 9:23 ` Nitin Yadav
0 siblings, 1 reply; 10+ messages in thread
From: Nishanth Menon @ 2023-09-14 16:04 UTC (permalink / raw)
To: Nitin Yadav
Cc: Krzysztof Kozlowski, vigneshr, rogerq, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt, catalin.marinas, will,
linux-arm-kernel, devicetree, linux-kernel
On 14:56-20230914, Nitin Yadav wrote:
> Hi Krzysztof,
>
> On 14/09/23 11:57, Krzysztof Kozlowski wrote:
> > On 13/09/2023 13:47, Nitin Yadav wrote:
> >> Add support for AM62Q NAND card: X8 NAND EXPANSION
> >> BOARD card (PROC143E1) for AM62x LP SK board.
Commit message is all too wrong as well. Sigh.
> >>
> >> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> >> ---
> >> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
> >> arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++
> >> 2 files changed, 31 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> >> index 284b90c94da8..e93e79d8083f 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> >> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> >> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
> >> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> >> status = "disabled";
> >> };
> >> + gpmc0: memory-controller@3b000000 {
> >> + status = "disabled";
> >
> > status is never first in DTSI. Really, where did you see such code?
> Thank for pointing out, Will send a revised version.
GPMC is not functional without board specific interface configuration
such as pinmux. this approach, in fact is all over the place now and
discussed in the mailing list multiple times now.
What is missing here is the documentation of the constraints as to why
it is set as disabled by default.
> >
> >> + compatible = "ti,am64-gpmc";
> >> + power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
> >
> > First is compatible, second is reg/reg-names/ranges.
> >
> >
> > Best regards,
> > Krzysztof
> >
>
> --
> Regards,
> Nitin
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support
2023-09-14 16:04 ` Nishanth Menon
@ 2023-09-15 9:23 ` Nitin Yadav
2023-09-15 12:22 ` Nishanth Menon
0 siblings, 1 reply; 10+ messages in thread
From: Nitin Yadav @ 2023-09-15 9:23 UTC (permalink / raw)
To: Nishanth Menon
Cc: Krzysztof Kozlowski, vigneshr, rogerq, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt, catalin.marinas, will,
linux-arm-kernel, devicetree, linux-kernel
On 14/09/23 21:34, Nishanth Menon wrote:
> On 14:56-20230914, Nitin Yadav wrote:
>> Hi Krzysztof,
>>
>> On 14/09/23 11:57, Krzysztof Kozlowski wrote:
>>> On 13/09/2023 13:47, Nitin Yadav wrote:
>>>> Add support for AM62Q NAND card: X8 NAND EXPANSION
>>>> BOARD card (PROC143E1) for AM62x LP SK board.
>
> Commit message is all too wrong as well. Sigh.
>
>>>>
>>>> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
>>>> ---
>>>> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
>>>> arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++
>>>> 2 files changed, 31 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>>>> index 284b90c94da8..e93e79d8083f 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>>>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>>>> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
>>>> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
>>>> status = "disabled";
>>>> };
>>>> + gpmc0: memory-controller@3b000000 {
>>>> + status = "disabled";
>>>
>>> status is never first in DTSI. Really, where did you see such code?
>> Thank for pointing out, Will send a revised version.
>
> GPMC is not functional without board specific interface configuration
> such as pinmux. this approach, in fact is all over the place now and
> discussed in the mailing list multiple times now.
>
> What is missing here is the documentation of the constraints as to why
> it is set as disabled by default.
gpmc nand is only am62x lp sk in am62x series. it has pinmux conflict
with macsp1, so disabling gpmc & elm by default for other am62 series.
For am62x lpsk in overlay macsp1 is disabled.
>
>
>>>
>>>> + compatible = "ti,am64-gpmc";
>>>> + power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
>>>
>>> First is compatible, second is reg/reg-names/ranges.
>>>
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> --
>> Regards,
>> Nitin
>
--
Regards,
Nitin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support
2023-09-13 11:47 ` [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support Nitin Yadav
2023-09-14 6:27 ` Krzysztof Kozlowski
@ 2023-09-15 11:16 ` Roger Quadros
1 sibling, 0 replies; 10+ messages in thread
From: Roger Quadros @ 2023-09-15 11:16 UTC (permalink / raw)
To: Nitin Yadav, nm, vigneshr
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
catalin.marinas, will, linux-arm-kernel, devicetree, linux-kernel
Hi Nitin,
On 13.9.2023 14.47, Nitin Yadav wrote:
> Add support for AM62Q NAND card: X8 NAND EXPANSION
> BOARD card (PROC143E1) for AM62x LP SK board.
This patch is not adding NAND support but GPMC and ELM nodes.
>
> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
> arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++
> 2 files changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 284b90c94da8..e93e79d8083f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> status = "disabled";
> };
> + gpmc0: memory-controller@3b000000 {
> + status = "disabled";
> + compatible = "ti,am64-gpmc";
> + power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&k3_clks 80 0>;
> + clock-names = "fck";
> + reg = <0x00 0x03b000000 0x00 0x400>,
> + <0x00 0x050000000 0x00 0x8000000>;
> + reg-names = "cfg", "data";
> + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> + gpmc,num-cs = <3>;
> + gpmc,num-waitpins = <2>;
> + #address-cells = <2>;
> + #size-cells = <1>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> + elm0: ecc@25010000 {
> + status = "disabled";
> + compatible = "ti,am3352-elm";
> + reg = <0x00 0x25010000 0x00 0x2000>;
> + interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&k3_pds 54 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&k3_clks 54 0>;
> + clock-names = "fck";
> + };
> };
> diff --git a/arch/arm64/boot/dts/ti/k3-am62.dtsi b/arch/arm64/boot/dts/ti/k3-am62.dtsi
> index 11f14eef2d44..f7d8aad0a016 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62.dtsi
> @@ -76,6 +76,8 @@ cbass_main: bus@f0000 {
> <0x00 0x70000000 0x00 0x70000000 0x00 0x00010000>, /* OCSRAM */
> <0x01 0x00000000 0x01 0x00000000 0x00 0x00310000>, /* A53 PERIPHBASE */
> <0x05 0x00000000 0x05 0x00000000 0x01 0x00000000>, /* FSS0 DAT3 */
> + <0x00 0x3b000000 0x00 0x3b000000 0x00 0x00000400>, /* GPMC0_CFG */
> + <0x00 0x50000000 0x00 0x50000000 0x00 0x08000000>, /* GPMC0 DATA */
>
> /* MCU Domain Range */
> <0x00 0x04000000 0x00 0x04000000 0x00 0x01ff1400>,
--
cheers,
-roger
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support
2023-09-15 9:23 ` Nitin Yadav
@ 2023-09-15 12:22 ` Nishanth Menon
0 siblings, 0 replies; 10+ messages in thread
From: Nishanth Menon @ 2023-09-15 12:22 UTC (permalink / raw)
To: Nitin Yadav
Cc: Krzysztof Kozlowski, vigneshr, rogerq, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt, catalin.marinas, will,
linux-arm-kernel, devicetree, linux-kernel
On 14:53-20230915, Nitin Yadav wrote:
>
>
> On 14/09/23 21:34, Nishanth Menon wrote:
> > On 14:56-20230914, Nitin Yadav wrote:
> >> Hi Krzysztof,
> >>
> >> On 14/09/23 11:57, Krzysztof Kozlowski wrote:
> >>> On 13/09/2023 13:47, Nitin Yadav wrote:
> >>>> Add support for AM62Q NAND card: X8 NAND EXPANSION
> >>>> BOARD card (PROC143E1) for AM62x LP SK board.
> >
> > Commit message is all too wrong as well. Sigh.
> >
> >>>>
> >>>> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> >>>> ---
> >>>> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
> >>>> arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++
> >>>> 2 files changed, 31 insertions(+)
> >>>>
> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> >>>> index 284b90c94da8..e93e79d8083f 100644
> >>>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> >>>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> >>>> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
> >>>> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> >>>> status = "disabled";
> >>>> };
> >>>> + gpmc0: memory-controller@3b000000 {
> >>>> + status = "disabled";
> >>>
> >>> status is never first in DTSI. Really, where did you see such code?
> >> Thank for pointing out, Will send a revised version.
> >
> > GPMC is not functional without board specific interface configuration
> > such as pinmux. this approach, in fact is all over the place now and
> > discussed in the mailing list multiple times now.
> >
> > What is missing here is the documentation of the constraints as to why
> > it is set as disabled by default.
> gpmc nand is only am62x lp sk in am62x series. it has pinmux conflict
> with macsp1, so disabling gpmc & elm by default for other am62 series.
> For am62x lpsk in overlay macsp1 is disabled.
When introducing a patch for SoC dtsi - explain in commit message and
code comments from the SoC's perspective, not the specific board
perspective.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-09-15 12:23 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-13 11:47 [PATCH 0/3] Add support for GPMC NAND Nitin Yadav
2023-09-13 11:47 ` [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support Nitin Yadav
2023-09-14 6:27 ` Krzysztof Kozlowski
2023-09-14 9:26 ` Nitin Yadav
2023-09-14 16:04 ` Nishanth Menon
2023-09-15 9:23 ` Nitin Yadav
2023-09-15 12:22 ` Nishanth Menon
2023-09-15 11:16 ` Roger Quadros
2023-09-13 11:47 ` [PATCH 2/3] arm64: dts: ti: Add GPMC NAND overlay Nitin Yadav
2023-09-13 11:47 ` [PATCH 3/3] arm64: defconfig: Enable GPMC NAND support Nitin Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).