From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: media: i2c: imx219: Remove redundant description of data-lanes
Date: Wed, 2 Apr 2025 12:29:17 +0200 [thread overview]
Message-ID: <32d36aba-9d7c-45f7-ab04-cb28ef31d159@kernel.org> (raw)
In-Reply-To: <20250402095749.GJ1240431@ragnatech.se>
On 02/04/2025 11:57, Niklas Söderlund wrote:
>>
>>> Support four-lane operation") the driver errored out if not 2 lanes
>>> where used, and after it if not 2 or 4 lanes where used.
>>
>> Then... fix the driver?
>>
>> This property describes hardware, not driver. Why current driver
>> implementation, e.g. 1 year ago or now, would change the hardware (so
>> the bindings)?
>
> I agree, I thought that here we have a case where the bindings predate
> the standardisation. The driver do not match the bindings, in fact it
> breaks if the imx219 specific instructions are followed. So the risk of
> breaking stuff is likely low. And this was an opportunity to align the
> imx219 with video-interfaces.yaml.
I am sorry, but what breaks exactly?
Is the device supporting two and four lanes setups? If yes, then the
binding is correct.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-02 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 14:57 [PATCH] dt-bindings: media: i2c: imx219: Remove redundant description of data-lanes Niklas Söderlund
2025-04-02 8:21 ` Krzysztof Kozlowski
2025-04-02 9:57 ` Niklas Söderlund
2025-04-02 10:29 ` Krzysztof Kozlowski [this message]
2025-04-02 11:08 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32d36aba-9d7c-45f7-ab04-cb28ef31d159@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox