From: Jeremy McNicoll <jmcnicol@redhat.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
Jeremy McNicoll <jeremymc@redhat.com>
Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
andy.gross@linaro.org, robh@kernel.org, arnd@arndb.de,
bjorn.andersson@linaro.org, riteshh@codeaurora.org, git@kchr.de,
ulf.hansson@linaro.org, jszhang@marvell.com,
linux-clk@vger.kernel.org
Subject: Re: [PATCH V3 1/6] dt-bindings: qcom: clk: Add missing binding for SDCHI enablement on Nexus 5X/6P
Date: Thu, 26 Jan 2017 16:58:14 -0500 [thread overview]
Message-ID: <32dcb31c-d102-3ea5-0951-835a3275df40@redhat.com> (raw)
In-Reply-To: <20170127002448.GB8801@codeaurora.org>
On 2017-01-26 7:24 PM, Stephen Boyd wrote:
> On 01/24, Jeremy McNicoll wrote:
>> AHB clock branch is needed in order to enable SDHCI
>> on msm899(2/4).
>>
>> Signed-off-by: Jeremy McNicoll <jeremymc@redhat.com>
>> ---
>
> Please cc linux-clk on clk patches (it helps my filters).
>
duly noted and added!
>
>> include/dt-bindings/clock/qcom,gcc-msm8994.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/dt-bindings/clock/qcom,gcc-msm8994.h b/include/dt-bindings/clock/qcom,gcc-msm8994.h
>> index 8fa535b..df47da0 100644
>> --- a/include/dt-bindings/clock/qcom,gcc-msm8994.h
>> +++ b/include/dt-bindings/clock/qcom,gcc-msm8994.h
>> @@ -133,5 +133,6 @@
>> #define GCC_USB30_MOCK_UTMI_CLK 115
>> #define GCC_USB3_PHY_AUX_CLK 116
>> #define GCC_USB_HS_SYSTEM_CLK 117
>> +#define GCC_SDCC1_AHB_CLK 118
>>
>
> Is there a driver patch too? Or just the #define addition.
>
This was split up as I believe I was told that we need to separate
the dt-bindings from the other code. Or should we combine them when
dealing with clocks?
The other part of this change looks just fine in my inbox.
Unfortunately that is the only place it got sent to. My bad.....
NAK.
Remember kids, cut twice measure once.
I'll send a V4 shortly.
-jeremy
next prev parent reply other threads:[~2017-01-26 21:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 9:36 [PATCH V3 0/6] Enable onboard SDHCI for Nexus 5X (msm8992) Jeremy McNicoll
2017-01-24 9:36 ` [PATCH V3 1/6] dt-bindings: qcom: clk: Add missing binding for SDCHI enablement on Nexus 5X/6P Jeremy McNicoll
2017-01-27 0:24 ` Stephen Boyd
2017-01-26 21:58 ` Jeremy McNicoll [this message]
2017-01-24 9:36 ` [PATCH V3 2/6] sdhci: Add quirk for delayed IRQ ACK Jeremy McNicoll
2017-01-25 10:18 ` Ritesh Harjani
2017-01-26 22:32 ` Jeremy McNicoll
2017-01-24 9:36 ` [PATCH V3 3/6] arm64: dts: msm8992 add fixed regulator Jeremy McNicoll
2017-01-24 9:36 ` [PATCH V3 4/6] arm64: dts: smem enablement for msm8992 Jeremy McNicoll
2017-01-24 9:36 ` [PATCH V3 5/6] dts: arm64: Enable onboard SDHCI on msm8992 Jeremy McNicoll
2017-01-24 9:36 ` [PATCH V3 6/6] dts: doc: rename rpm_requests to respect DT naming conventions Jeremy McNicoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32dcb31c-d102-3ea5-0951-835a3275df40@redhat.com \
--to=jmcnicol@redhat.com \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=git@kchr.de \
--cc=jeremymc@redhat.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=riteshh@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).