* [PATCH 2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label
2024-08-16 10:23 [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID Bartosz Golaszewski
@ 2024-08-16 10:23 ` Bartosz Golaszewski
2024-08-16 14:05 ` Krzysztof Kozlowski
2024-08-16 11:21 ` [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Bartosz Golaszewski @ 2024-08-16 10:23 UTC (permalink / raw)
To: Srinivas Kandagatla, Amol Maheshwari, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Tengfei Fan, Ling Xu
Cc: linux-arm-msm, dri-devel, devicetree, linux-kernel,
Bartosz Golaszewski, Ekansh Gupta
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The fastrpc driver uses the label to determine the domain ID and create
the device nodes. It should be "cdsp1" as this is the engine we use here.
Fixes: df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes")
Reported-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 801e8a92359d..5b9b68c634f5 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -4046,7 +4046,7 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
fastrpc {
compatible = "qcom,fastrpc";
qcom,glink-channels = "fastrpcglink-apps-dsp";
- label = "cdsp";
+ label = "cdsp1";
#address-cells = <1>;
#size-cells = <0>;
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label
2024-08-16 10:23 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label Bartosz Golaszewski
@ 2024-08-16 14:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-16 14:05 UTC (permalink / raw)
To: Bartosz Golaszewski, Srinivas Kandagatla, Amol Maheshwari,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Tengfei Fan, Ling Xu
Cc: linux-arm-msm, dri-devel, devicetree, linux-kernel,
Bartosz Golaszewski, Ekansh Gupta
On 16/08/2024 12:23, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The fastrpc driver uses the label to determine the domain ID and create
> the device nodes. It should be "cdsp1" as this is the engine we use here.
>
> Fixes: df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes")
> Reported-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID
2024-08-16 10:23 [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID Bartosz Golaszewski
2024-08-16 10:23 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label Bartosz Golaszewski
@ 2024-08-16 11:21 ` Krzysztof Kozlowski
2024-08-16 12:29 ` Bartosz Golaszewski
2024-08-16 14:05 ` Krzysztof Kozlowski
2024-08-20 22:12 ` (subset) " Bjorn Andersson
3 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-16 11:21 UTC (permalink / raw)
To: Bartosz Golaszewski, Srinivas Kandagatla, Amol Maheshwari,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Tengfei Fan, Ling Xu
Cc: linux-arm-msm, dri-devel, devicetree, linux-kernel,
Bartosz Golaszewski
On 16/08/2024 12:23, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> index c27a8f33d8d7..2a5b18982804 100644
> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> @@ -26,6 +26,7 @@ properties:
> - mdsp
> - sdsp
> - cdsp
> + - cdsp1
Are there more than one cdsp domains? Why adding suffixes? Driver source
code does not have "cdsp1" domain, so this is confusing.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID
2024-08-16 11:21 ` [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID Krzysztof Kozlowski
@ 2024-08-16 12:29 ` Bartosz Golaszewski
2024-08-16 14:05 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Bartosz Golaszewski @ 2024-08-16 12:29 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Srinivas Kandagatla, Amol Maheshwari, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Tengfei Fan, Ling Xu, linux-arm-msm, dri-devel, devicetree,
linux-kernel, Bartosz Golaszewski
On Fri, Aug 16, 2024 at 1:21 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 16/08/2024 12:23, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> > index c27a8f33d8d7..2a5b18982804 100644
> > --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> > +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> > @@ -26,6 +26,7 @@ properties:
> > - mdsp
> > - sdsp
> > - cdsp
> > + - cdsp1
>
> Are there more than one cdsp domains? Why adding suffixes? Driver source
> code does not have "cdsp1" domain, so this is confusing.
>
> Best regards,
> Krzysztof
>
It does, Srini picked up this patch earlier today. I'm not an expert
in fast RPC but it looks like the domain ID number matters here.
Bart
[1] https://lore.kernel.org/all/20240805-topic-sa8775p-iot-remoteproc-v4-4-86affdc72c04@linaro.org/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID
2024-08-16 12:29 ` Bartosz Golaszewski
@ 2024-08-16 14:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-16 14:05 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Srinivas Kandagatla, Amol Maheshwari, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Tengfei Fan, Ling Xu, linux-arm-msm, dri-devel, devicetree,
linux-kernel, Bartosz Golaszewski
On 16/08/2024 14:29, Bartosz Golaszewski wrote:
> On Fri, Aug 16, 2024 at 1:21 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 16/08/2024 12:23, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>> ---
>>> Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>>> index c27a8f33d8d7..2a5b18982804 100644
>>> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>>> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
>>> @@ -26,6 +26,7 @@ properties:
>>> - mdsp
>>> - sdsp
>>> - cdsp
>>> + - cdsp1
>>
>> Are there more than one cdsp domains? Why adding suffixes? Driver source
>> code does not have "cdsp1" domain, so this is confusing.
>>
>> Best regards,
>> Krzysztof
>>
>
> It does, Srini picked up this patch earlier today. I'm not an expert
> in fast RPC but it looks like the domain ID number matters here.
Ah, ok, I did not see driver change here so it was a bit confusing.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID
2024-08-16 10:23 [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID Bartosz Golaszewski
2024-08-16 10:23 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label Bartosz Golaszewski
2024-08-16 11:21 ` [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID Krzysztof Kozlowski
@ 2024-08-16 14:05 ` Krzysztof Kozlowski
2024-08-20 22:12 ` (subset) " Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-16 14:05 UTC (permalink / raw)
To: Bartosz Golaszewski, Srinivas Kandagatla, Amol Maheshwari,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Tengfei Fan, Ling Xu
Cc: linux-arm-msm, dri-devel, devicetree, linux-kernel,
Bartosz Golaszewski
On 16/08/2024 12:23, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID
2024-08-16 10:23 [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID Bartosz Golaszewski
` (2 preceding siblings ...)
2024-08-16 14:05 ` Krzysztof Kozlowski
@ 2024-08-20 22:12 ` Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2024-08-20 22:12 UTC (permalink / raw)
To: Srinivas Kandagatla, Amol Maheshwari, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio, Tengfei Fan,
Ling Xu, Bartosz Golaszewski
Cc: linux-arm-msm, dri-devel, devicetree, linux-kernel,
Bartosz Golaszewski
On Fri, 16 Aug 2024 12:23:44 +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.
>
>
Applied, thanks!
[2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label
commit: b45af698d5114f9b666c7d8b58a9111d0526d7f7
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread