From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wu, Songjun" Subject: Re: [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial Date: Tue, 19 Jun 2018 14:46:27 +0800 Message-ID: <32ff76eb-6711-f0f2-2d83-6887a961855f@linux.intel.com> References: <20180612054034.4969-1-songjun.wu@linux.intel.com> <20180612054034.4969-2-songjun.wu@linux.intel.com> <539411c1-82b7-cf76-71cf-d50f3303f50f@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: hua.ma@linux.intel.com, yixin.zhu@linux.intel.com, chuanhua.lei@intel.com, "open list:RALINK MIPS ARCHITECTURE" , qi-ming.wu@intel.com, linux-clk , linux-serial@vger.kernel.org, DTML , James Hogan , Linux Kernel Mailing List , Thomas Gleixner , Philippe Ombredanne , Rob Herring , Kate Stewart , Greg Kroah-Hartman , Mark Rutland , Ralf Baechle List-Id: devicetree@vger.kernel.org On 6/18/2018 6:59 PM, Arnd Bergmann wrote: > On Mon, Jun 18, 2018 at 11:42 AM, Wu, Songjun > wrote: >> On 6/14/2018 6:03 PM, Arnd Bergmann wrote: >>> On Tue, Jun 12, 2018 at 7:40 AM, Songjun Wu >>> wrote: >>>> Previous implementation uses a hard-coded register value to check if >>>> the current serial entity is the console entity. >>>> Now the lantiq serial driver uses the aliases for the index of the >>>> serial port. >>>> The lantiq danube serial dts are updated with aliases to support this. >>>> >>>> Signed-off-by: Songjun Wu >>>> --- >>>> >>>> arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi >>>> b/arch/mips/boot/dts/lantiq/danube.dtsi >>>> index 2dd950181f8a..7a9e15da6bd0 100644 >>>> --- a/arch/mips/boot/dts/lantiq/danube.dtsi >>>> +++ b/arch/mips/boot/dts/lantiq/danube.dtsi >>>> @@ -4,6 +4,10 @@ >>>> #size-cells = <1>; >>>> compatible = "lantiq,xway", "lantiq,danube"; >>>> >>>> + aliases { >>>> + serial0 = &asc1; >>>> + }; >>>> + >>> You generally want the aliases to be part of the board specific file, >>> not every board numbers their serial ports in the same way. >>> >> In this chip only asc1 can be used as console, so serial0 is defined in >> chip specific file. > This was a more general comment about 'aliases' being board specific > in principle (though we've had exceptions in the past). Even if there > is only one uart on the chip, I'd recommend following the same > conventions as the other chips that have more than one uart. > > Arnd Accept, 'aliases' will be move to the board specific file.