From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE67EEAC for ; Sun, 22 Oct 2023 18:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q+P+Wc9V" Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E6B7E0 for ; Sun, 22 Oct 2023 11:46:10 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9be1ee3dc86so367826766b.1 for ; Sun, 22 Oct 2023 11:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698000369; x=1698605169; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9jG3P+jRF5kVGk6CFsI11BtDJxKDzNxKy4q/HNvCw7w=; b=Q+P+Wc9VRVBwp0pLDJJJufBV4jI1/8XXBE/NJdB3r1Ic5bL3hAJjhO7e7l3TC6KkvV e+alF4As6rctl+a52Sulh+447/IdDkf84I1U8LEGr8kpGLgL6Iy4mGZywmuGF+rGPMi5 a3+99snjcg0wUWkUeICz+6xsZnscY1XEA9ahQ+PWuULk7CYaOPpI/g7qsfqU1G0/LL1O ER6DXmK8WSY8DkJ+8CABi1/4TgQ7RDk7BtQNbX5uT8b4h8udc5ay02mD59Sm2gt0rOV9 NTEU11clCsqi22lUh2xgRic1YbD0hT9xAYFRITNmdrHG8UJ6ljeUhZSoG+V043NpLQkZ 5vxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698000369; x=1698605169; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9jG3P+jRF5kVGk6CFsI11BtDJxKDzNxKy4q/HNvCw7w=; b=COQC05auH5i0xb82IyepvK87Y2iIRF0nH/4tb82+xl0pCkjTKm3CNUtAPmKxj5OshN /FVj7s5xIvzWJQ6d+OdZR/lfDJWG3h0ctlY6Mcz2Rr59Nxh2dAM6prhVta+RLJDEnN0+ 95VbU9UiMVZr6nj+VxthJ2hZ16ZuXKkckgLU/Pa6N7wavE0T63okGYeVF4PoInuUzBMt SRunJA94ISzwNxFG/VyGjBYArvxvnCfYq4MOHYoXiP7pQyYpceWCthjV+0yAA02GRFYj JwMU6kb6j93Mc1vKDfUK1a2CdaW7JQU0O4AxhQ+pQnMY5l4U5pnZuAWTMfMszAHRuHkI JO/g== X-Gm-Message-State: AOJu0YxsSV8FLX7kguBoPysY7BzISHLShaKnnUOgZw9UGQDjpZhEFqnF 6AnldFyUGnx2jSaGmXQ4TgNPYA== X-Google-Smtp-Source: AGHT+IGnvYQJ84z36CRbqHYncNuUq9WpKhqIP6bQ/DnagUTB8ZHJoYZggir8zL4NoxC5P5C9XhuI6Q== X-Received: by 2002:a17:907:3188:b0:9c7:4d3e:1e50 with SMTP id xe8-20020a170907318800b009c74d3e1e50mr5411501ejb.76.1698000368952; Sun, 22 Oct 2023 11:46:08 -0700 (PDT) Received: from [192.168.1.20] ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id f7-20020a1709062c4700b009c3828fec06sm5331727ejh.81.2023.10.22.11.46.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Oct 2023 11:46:08 -0700 (PDT) Message-ID: <3307fcb9-1697-4a9e-b4f6-c00c2b10ba89@linaro.org> Date: Sun, 22 Oct 2023 20:46:06 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree Content-Language: en-US To: Luka Panio , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , Tony Luck , "Guilherme G . Piccoli" , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20231022173811.8229-1-lukapanio@gmail.com> <20231022173811.8229-2-lukapanio@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231022173811.8229-2-lukapanio@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/10/2023 19:38, Luka Panio wrote: > Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc. > > Signed-off-by: Luka Panio > --- > v2: > Update commit message. Drop reserved gpio's as this device in reality do not have gpio, and pins are not protected. > > v3: > Update commit message. > > v4: > Update commit message. > > v5: > Update commit message. > > v6: > Update commit message. > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/sm8250-xiaomi-pipa.dts | 625 ++++++++++++++++++ > 2 files changed, 626 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 2cca20563a1d..41ab333d1f81 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -208,6 +208,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-boe.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish-csot.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-pipa.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8350-hdk.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8350-microsoft-surface-duo2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8350-mtp.dtb > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts > new file mode 100644 > index 000000000000..41eae1aaa2a8 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts > @@ -0,0 +1,625 @@ > +// SPDX-License-Identifier: BSD-3-Clause If there are no other copyrights here, why did you use BSD-3 license? > +/* > + * Copyright (c) 2023 luka177 > + */ > + > +/dts-v1/; > + > +#include > +#include > +#include > +#include "sm8250.dtsi" > +#include "pm8150.dtsi" > +#include "pm8150b.dtsi" > +#include "pm8150l.dtsi" > +#include "pm8009.dtsi" > + > +/* > + * Delete following upstream (sm8250.dtsi) reserved > + * memory mappings which are different on this device. > + */ > +/delete-node/ &adsp_mem; > +/delete-node/ &cdsp_secure_heap; > +/delete-node/ &slpi_mem; > +/delete-node/ &spss_mem; > +/delete-node/ &xbl_aop_mem; > + > +/ { > + > + model = "Xiaomi Pad 6"; > + compatible = "xiaomi,pipa", "qcom,sm8250"; > + > + classis-type = "tablet"; chassis-type It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). > + > + /* required for bootloader to select correct board */ > + qcom,msm-id = ; /* SM8250 v2.1 */ > + qcom,board-id = <0x34 0>; 0x34 or 34? > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; .... > + > +&i2c13 { > + clock-frequency = <400000>; > + status = "okay"; > + > + fuel-gauge@55 { > + compatible = "ti,bq27z561"; > + reg = <0x55>; > + monitored-battery = <&battery_l>; > + }; > +}; > + > + > + Just one blank line > +&pcie0 { > + status = "okay"; > +}; > + > +&pcie0_phy { > + vdda-phy-supply = <&vreg_l5a_0p88>; > + vdda-pll-supply = <&vreg_l9a_1p2>; > + status = "okay"; > +}; Best regards, Krzysztof