From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/3] [media] mt9v032: Add reset and standby gpios Date: Mon, 09 Nov 2015 18:15:56 +0200 Message-ID: <3310512.E4vEfn7BXV@avalon> References: <1446815625-18413-1-git-send-email-mpa@pengutronix.de> <1763974.WDKlRvPG0G@avalon> <5144598.EqybrDukyg@adelgunde> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <5144598.EqybrDukyg@adelgunde> Sender: linux-media-owner@vger.kernel.org To: Markus Pargmann Cc: Hans Verkuil , Philipp Zabel , devicetree@vger.kernel.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Markus, On Monday 09 November 2015 16:33:03 Markus Pargmann wrote: > On Monday 09 November 2015 14:28:56 Laurent Pinchart wrote: > > On Friday 06 November 2015 14:13:43 Markus Pargmann wrote: > >> Add optional reset and standby gpios. The reset gpio is used to reset > >> the chip in power_on(). > >> > >> The standby gpio is not used currently. It is just unset, so the chip is > >> not in standby. > > > > We could use a gpio hog for this, but given that the standby signal should > > eventually get used, and given that specifying it in DT is a good hardware > > description, that looks good to me. > > > >> Signed-off-by: Markus Pargmann > >> Reviewed-by: Philipp Zabel > >> --- > >> > >> .../devicetree/bindings/media/i2c/mt9v032.txt | 2 ++ > >> drivers/media/i2c/mt9v032.c | 23 +++++++++++++++ > >> 2 files changed, 25 insertions(+) [snip] > > If you're fine with these changes there's no need to resubmit the patch, I > > can fix it when applying it to my tree. > > Thanks, I am fine with all your changes. But as there will be a v2 for the > other two patches I could as well send an updated version if you wish. As you wish, both options are fine with me. -- Regards, Laurent Pinchart