devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/of: Add devm_of_iomap()
Date: Fri, 15 Jun 2018 09:50:54 +1000	[thread overview]
Message-ID: <3312487e2b61b8c2f265d210d14bbed8681a9ecc.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAMuHMdVixknUDYZUHafCqNY02z=T-WC2s+Qh6GkpejmoJU0fuQ@mail.gmail.com>

On Thu, 2018-06-14 at 10:27 +0200, Geert Uytterhoeven wrote:
> > --- a/include/linux/of_address.h
> > +++ b/include/linux/of_address.h
> > @@ -40,6 +40,11 @@ extern void __iomem *of_iomap(struct device_node *device, int index);
> >   void __iomem *of_io_request_and_map(struct device_node *device,
> >                                      int index, const char *name);
> > 
> > +/* Request and map, wrapper on devm_ioremap_resource */
> > +extern void __iomem *devm_of_iomap(struct device *dev,
> > +                                  struct device_node *node, int index,
> > +                                  resource_size_t *size);
> > +
> >   /* Extract an address from a device, returns the region size and
> >    * the address space flags too. The PCI version uses a BAR number
> >    * instead of an absolute index
> 
> Do you need a dummy for !CONFIG_OF_ADDRESS, to aid compile-testing?

I didn't think so, as of_address_to_resource() already has a dummy, so
it should build fine.

Cheers,
Ben.

  reply	other threads:[~2018-06-14 23:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  0:01 [PATCH] drivers/of: Add devm_of_iomap() Benjamin Herrenschmidt
2018-06-12  8:35 ` Andy Shevchenko
2018-06-12 10:28   ` Benjamin Herrenschmidt
2018-06-12 16:53     ` Andy Shevchenko
2018-06-12 22:58       ` Benjamin Herrenschmidt
2018-06-12 23:16         ` Andy Shevchenko
2018-06-13  0:18           ` Benjamin Herrenschmidt
2018-06-13  8:18             ` Andy Shevchenko
2018-06-12 17:42 ` Rob Herring
2018-06-12 22:53   ` Benjamin Herrenschmidt
2018-06-13 15:00     ` Rob Herring
2018-06-13 23:07       ` Benjamin Herrenschmidt
2018-06-14  8:27 ` Geert Uytterhoeven
2018-06-14 23:50   ` Benjamin Herrenschmidt [this message]
2018-06-15  6:16     ` Geert Uytterhoeven
2018-06-15  6:52       ` Benjamin Herrenschmidt
2018-06-14 13:30 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3312487e2b61b8c2f265d210d14bbed8681a9ecc.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).