* [PATCH] MIPS: dts: Boston: Fix dtc 'pci_device_reg' warning
@ 2023-02-13 6:24 Genjian
2023-02-13 7:43 ` Philippe Mathieu-Daudé
2023-02-17 11:04 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Genjian @ 2023-02-13 6:24 UTC (permalink / raw)
To: paulburton, robh+dt, krzysztof.kozlowski+dt, tsbogend
Cc: linux-mips, devicetree, linux-kernel, Genjian Zhang, k2ci
From: Genjian Zhang <zhanggenjian@kylinos.cn>
dtbs_check currently complains that:
arch/mips/boot/dts/img/boston.dts:128.19-178.5: Warning (pci_device_reg):
/pci@14000000/pci2_root@0,0,0: PCI unit address format error,
expected "0,0"
The unit-address format should be '<device>,<function>'.
Fix the unit-address accordingly.
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
---
arch/mips/boot/dts/img/boston.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index 84328afa3a55..72f7605d2e31 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -125,7 +125,7 @@ pci2_intc: interrupt-controller {
#interrupt-cells = <1>;
};
- pci2_root@0,0,0 {
+ pci2_root@0,0 {
compatible = "pci10ee,7021";
reg = <0x00000000 0 0 0 0>;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: dts: Boston: Fix dtc 'pci_device_reg' warning
2023-02-13 6:24 [PATCH] MIPS: dts: Boston: Fix dtc 'pci_device_reg' warning Genjian
@ 2023-02-13 7:43 ` Philippe Mathieu-Daudé
2023-02-17 11:04 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-13 7:43 UTC (permalink / raw)
To: Genjian, paulburton, robh+dt, krzysztof.kozlowski+dt, tsbogend
Cc: linux-mips, devicetree, linux-kernel, Genjian Zhang, k2ci
On 13/2/23 07:24, Genjian wrote:
> From: Genjian Zhang <zhanggenjian@kylinos.cn>
>
> dtbs_check currently complains that:
> arch/mips/boot/dts/img/boston.dts:128.19-178.5: Warning (pci_device_reg):
> /pci@14000000/pci2_root@0,0,0: PCI unit address format error,
> expected "0,0"
> The unit-address format should be '<device>,<function>'.
> Fix the unit-address accordingly.
>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
> ---
> arch/mips/boot/dts/img/boston.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: dts: Boston: Fix dtc 'pci_device_reg' warning
2023-02-13 6:24 [PATCH] MIPS: dts: Boston: Fix dtc 'pci_device_reg' warning Genjian
2023-02-13 7:43 ` Philippe Mathieu-Daudé
@ 2023-02-17 11:04 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2023-02-17 11:04 UTC (permalink / raw)
To: Genjian
Cc: paulburton, robh+dt, krzysztof.kozlowski+dt, linux-mips,
devicetree, linux-kernel, Genjian Zhang, k2ci
On Mon, Feb 13, 2023 at 02:24:51PM +0800, Genjian wrote:
> From: Genjian Zhang <zhanggenjian@kylinos.cn>
>
> dtbs_check currently complains that:
> arch/mips/boot/dts/img/boston.dts:128.19-178.5: Warning (pci_device_reg):
> /pci@14000000/pci2_root@0,0,0: PCI unit address format error,
> expected "0,0"
> The unit-address format should be '<device>,<function>'.
> Fix the unit-address accordingly.
>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
> ---
> arch/mips/boot/dts/img/boston.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
> index 84328afa3a55..72f7605d2e31 100644
> --- a/arch/mips/boot/dts/img/boston.dts
> +++ b/arch/mips/boot/dts/img/boston.dts
> @@ -125,7 +125,7 @@ pci2_intc: interrupt-controller {
> #interrupt-cells = <1>;
> };
>
> - pci2_root@0,0,0 {
> + pci2_root@0,0 {
> compatible = "pci10ee,7021";
> reg = <0x00000000 0 0 0 0>;
>
> --
> 2.25.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-17 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-13 6:24 [PATCH] MIPS: dts: Boston: Fix dtc 'pci_device_reg' warning Genjian
2023-02-13 7:43 ` Philippe Mathieu-Daudé
2023-02-17 11:04 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).