From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF7C9C4332F for ; Tue, 20 Dec 2022 17:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229536AbiLTRcc (ORCPT ); Tue, 20 Dec 2022 12:32:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233896AbiLTRcN (ORCPT ); Tue, 20 Dec 2022 12:32:13 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CDC81A3B0; Tue, 20 Dec 2022 09:32:11 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p7gTI-00085n-EU; Tue, 20 Dec 2022 18:32:08 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Yuteng Zhong , Krzysztof Kozlowski Cc: Rob Herring , Peter Geis , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, DHDAXCW Subject: Re: [PATCH v2] arm64: dts: rockchip: Add RK3566 LubanCat 1 Date: Tue, 20 Dec 2022 18:32:06 +0100 Message-ID: <3325915.e9J7NaK4W3@diego> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, 20. Dezember 2022, 17:14:51 CET schrieb Krzysztof Kozlowski: > On 20/12/2022 11:21, Yuteng Zhong wrote: > > LubanCat 1 is a Rockchip RK3566 SBC based > > is developed by EmbedFire Electronics Co., Ltd. > > Mini Linux Card Type Cheap Computer Development Board > > Please wrap commit message according to Linux coding style / submission > process: > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > > + rk809: pmic@20 { > > + compatible = "rockchip,rk809"; > > + reg = <0x20>; > > + interrupt-parent = <&gpio0>; > > + interrupts = ; > > + assigned-clocks = <&cru I2S1_MCLKOUT_TX>; > > + assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>; > > + #clock-cells = <1>; > > + clock-names = "mclk"; > > + clocks = <&cru I2S1_MCLKOUT_TX>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pmic_int>; > > + rockchip,system-power-controller; > > + #sound-dai-cells = <0>; > > + vcc1-supply = <&vcc3v3_sys>; > > + vcc2-supply = <&vcc3v3_sys>; > > + vcc3-supply = <&vcc3v3_sys>; > > + vcc4-supply = <&vcc3v3_sys>; > > + vcc5-supply = <&vcc3v3_sys>; > > + vcc6-supply = <&vcc3v3_sys>; > > + vcc7-supply = <&vcc3v3_sys>; > > + vcc8-supply = <&vcc3v3_sys>; > > + vcc9-supply = <&vcc3v3_sys>; > > + wakeup-source; > > + > > + regulators { > > + vdd_logic: DCDC_REG1 { > > No underscores in node names. Anything requires it? looks like the answer is "it depends" :-) When the regulator-framework searches for the node to get the init-data from it uses the actual node-name or the regulator-compatible property [0] to match against. And going via regulator-compatible was the "old" way, already deprecated before the yaml-conversion [1] and not even included So matching against the node-name is the correct way to go and it's actually part of the rk8xx-binding as well [2] Hope that helps, Heiko [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/regulator/of_regulator.c#n477 [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/devicetree/bindings/regulator/regulator.txt?id=1914a996436b09186489da73b807e1df71259f67 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml#n84