RE: [PATCH v8 2/2] ASoC: dt-bindings: realtek,rt5575: add bindings for ALC5575

[Oder Chiou <oder_chiou@realtek.com>]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Friday, December 5, 2025 4:31 PM
> To: Oder Chiou <oder_chiou@realtek.com>
> Cc: cezary.rojewski@intel.com; broonie@kernel.org; lgirdwood@gmail.com;
> robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; perex@perex.cz;
> linux-sound@vger.kernel.org; devicetree@vger.kernel.org;
> alsa-devel@alsa-project.org; Flove(HsinFu) <flove@realtek.com>; Shuming [范
> 書銘] <shumingf@realtek.com>; Jack Yu <jack.yu@realtek.com>; Derek [方德
> 義] <derek.fang@realtek.com>
> Subject: Re: [PATCH v8 2/2] ASoC: dt-bindings: realtek,rt5575: add bindings for
> ALC5575
> 
> 
> External mail : This email originated from outside the organization. Do not
> reply, click links, or open attachments unless you recognize the sender and
> know the content is safe.
> 
> 
> 
> On Mon, Dec 01, 2025 at 06:59:26PM +0800, Oder Chiou wrote:
> > Realtek ALC5575 is a highly advanced DSP and microphone CODEC that has
> > been designed for AI audio technology. Its impressive features include
> > an advanced HiFi-5 DSP core, a Neural Network Processing Unit (NPU)
> > owned by Realtek, and embedded 4MB memory, which enables it to operate
> > highly advanced AI audio algorithms. The ALC5575 supports 4xA-mic input
> > and 8xD-mic input, as well as a rich set of interfaces such as I2S, I2C,
> > SPI, and UART.
> 
> When I asked to describe hardware, I did not meant marketing junk! Drop
> all impressive features and simply describe hardware in basic terms.
> This is not advanced DSP, not designed for AI audio (AI is the easiest way to
> get a grumpy review), not "highly advanced AI audio algorithms" and does
> not have "as a rich set of interfaces".
> 
> Use simple terms what is this. Audio codec with I2S.... interfaces.

The description will be change to
Audio codec with I2S, I2C and SPI.

> >
> > Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
> > ---
> >  .../bindings/sound/realtek,rt5575.yaml        | 44
> +++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/sound/realtek,rt5575.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5575.yaml
> b/Documentation/devicetree/bindings/sound/realtek,rt5575.yaml
> > new file mode 100644
> > index 000000000000..83ccc79e6769
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5575.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/realtek,rt5575.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ALC5575 audio CODEC
> > +
> > +maintainers:
> > +  - Oder Chiou <oder_chiou@realtek.com>
> > +
> > +description:
> > +  The device supports both I2C and SPI. I2C is mandatory, while SPI is
> > +  optional depending on the hardware configuration.
> > +
> > +allOf:
> > +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> > +  - $ref: dai-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - realtek,rt5575
> > +      - realtek,rt5575-with-spi
> 
> Drop the second compatible. It's the same device. Whether it supports
> SPI it is already known and obvious - you cannot place non-SPI chip on
> SPI bus and expect it to work.

There are two hardware configurations: with SPI flash and without SPI flash.
If the codec is shipped without an SPI flash, the SPI driver can still load
the firmware through the SPI interface. The second compatible is intended to
distinguish between the versions with and without the SPI flash.