Re: [PATCH 4/7] ARM: dts: ls1021a-tqmals1021a: Add LVDS overlay for Tianma TM070JVGH33

[Alexander Stein <alexander.stein@ew.tq-group.com>]

Hi Frank,

Am Donnerstag, 27. März 2025, 16:00:32 CET schrieb Frank Li:
> On Thu, Mar 27, 2025 at 03:41:10PM +0100, Alexander Stein wrote:
> > This adds an overlay for the supported LVDS display tianma tm070jvhg33.
> > The on-board RGB-to-LVDS encoder and DCU graphics chain are configured
> > accordingly. Add the missing power supply as well.
> 
> 		      ^^^ missed?

Thanks for the comment. We are touching English grammar here and I might
be completely wrong.
IMHO this gerund is describing the power supply is missing the whole time.
In contrast to 'missed' which indicates it had been missed (just) once.
Anyway I don't have hard feelings.

Best regards,
Alexander

> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >  arch/arm/boot/dts/nxp/ls/Makefile             |  2 +
> >  ...tqmls1021a-mbls1021a-lvds-tm070jvhg33.dtso | 47 +++++++++++++++++++
> >  .../nxp/ls/ls1021a-tqmls1021a-mbls1021a.dts   |  1 +
> >  3 files changed, 50 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/nxp/ls/ls1021a-tqmls1021a-mbls1021a-lvds-tm070jvhg33.dtso
> >
> > diff --git a/arch/arm/boot/dts/nxp/ls/Makefile b/arch/arm/boot/dts/nxp/ls/Makefile
> > index 225a7665b8ad1..7f96de6f80224 100644
> > --- a/arch/arm/boot/dts/nxp/ls/Makefile
> > +++ b/arch/arm/boot/dts/nxp/ls/Makefile
> > @@ -8,4 +8,6 @@ dtb-$(CONFIG_SOC_LS1021A) += \
> >  	ls1021a-twr.dtb
> >
> >  ls1021a-tqmls1021a-mbls1021a-hdmi-dtbs += ls1021a-tqmls1021a-mbls1021a.dtb ls1021a-tqmls1021a-mbls1021a-hdmi.dtbo
> > +ls1021a-tqmls1021a-mbls1021a-lvds-tm070jvhg33-dtbs += ls1021a-tqmls1021a-mbls1021a.dtb ls1021a-tqmls1021a-mbls1021a-lvds-tm070jvhg33.dtbo
> >  dtb-$(CONFIG_SOC_LS1021A) += ls1021a-tqmls1021a-mbls1021a-hdmi.dtb
> > +dtb-$(CONFIG_SOC_LS1021A) += ls1021a-tqmls1021a-mbls1021a-lvds-tm070jvhg33.dtb
> > diff --git a/arch/arm/boot/dts/nxp/ls/ls1021a-tqmls1021a-mbls1021a-lvds-tm070jvhg33.dtso b/arch/arm/boot/dts/nxp/ls/ls1021a-tqmls1021a-mbls1021a-lvds-tm070jvhg33.dtso
> > new file mode 100644
> > index 0000000000000..e9708f3c67403
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/nxp/ls/ls1021a-tqmls1021a-mbls1021a-lvds-tm070jvhg33.dtso
> > @@ -0,0 +1,47 @@
> > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> > +/*
> > + * Copyright 2013-2014 Freescale Semiconductor, Inc.
> > + * Copyright 2018-2025 TQ-Systems GmbH <linux@ew.tq-group.com>,
> > + * D-82229 Seefeld, Germany.
> > + * Author: Alexander Stein
> > + */
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +&backlight_dcu {
> > +	status = "okay";
> > +};
> > +
> > +&dcu {
> > +	status = "okay";
> > +
> > +	port {
> > +		dcu_out: endpoint {
> > +			remote-endpoint = <&lvds_encoder_in>;
> > +		};
> > +	};
> > +};
> > +
> > +&display {
> > +	compatible = "tianma,tm070jvhg33";
> > +	status = "okay";
> > +};
> > +
> > +&lvds_encoder {
> > +	status = "okay";
> > +};
> > +
> > +&lvds_encoder_in {
> > +	remote-endpoint = <&dcu_out>;
> > +};
> > +
> > +&lvds_encoder_out {
> > +	remote-endpoint = <&panel_in>;
> > +};
> > +
> > +&panel_in {
> > +	remote-endpoint = <&lvds_encoder_out>;
> > +};
> > diff --git a/arch/arm/boot/dts/nxp/ls/ls1021a-tqmls1021a-mbls1021a.dts b/arch/arm/boot/dts/nxp/ls/ls1021a-tqmls1021a-mbls1021a.dts
> > index 27a55fa638128..80dae0c09542d 100644
> > --- a/arch/arm/boot/dts/nxp/ls/ls1021a-tqmls1021a-mbls1021a.dts
> > +++ b/arch/arm/boot/dts/nxp/ls/ls1021a-tqmls1021a-mbls1021a.dts
> > @@ -147,6 +147,7 @@ hdmi_in: endpoint {
> >  	display: panel {
> >  		backlight = <&backlight_dcu>;
> >  		enable-gpios = <&pca9554_1 3 GPIO_ACTIVE_HIGH>;
> > +		power-supply = <&reg_3p3v>;
> >  		status = "disabled";
> >
> >  		port {
> > --
> > 2.43.0
> >
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/