From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D9CC433FE for ; Mon, 7 Nov 2022 08:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbiKGI3a (ORCPT ); Mon, 7 Nov 2022 03:29:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbiKGI33 (ORCPT ); Mon, 7 Nov 2022 03:29:29 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 592481D3 for ; Mon, 7 Nov 2022 00:29:28 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id g7so15740711lfv.5 for ; Mon, 07 Nov 2022 00:29:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+G+Z3fRjw+YmVPah8QnDEbPwrQNevzGVNtku2Zteqko=; b=p/Ivu84VjaM2s6AOOjS2hGlpuazO2Ifv/qX1ZLT5UgyP37/xADglycLuhgfyqSjppS a85YRL3hjoYVYNjpEANZEBQw4A3ra2/S7Lx6eI6Jxqdk0+oqUWkAK5LDMKqRGsEMPASK 9X+itdiBrXDbpxpEPygy9iOHvWAk9xvIVOpGy2sVlc1/Un5ZBNaOP5Xuej51L9khne6P jz8jfGaPMEzTRoSyt7ACKf3kXdxiFGoj3PnGkfjAY3/uVsdBpoB7DevdXZDv9Z+m9dxa RBnjjk27Yt3Mbme5DRNBNyc+yAG6pQaAJrXQIx4t7K9kfoYc2emH1pPLWY+fPCjEb9JP TpVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+G+Z3fRjw+YmVPah8QnDEbPwrQNevzGVNtku2Zteqko=; b=0eqyuofDxSCjsbuLEQLSIGO4Ey8kVP0SJ+5G5gPmf/yiYKRx1QbCidEbDs7tyFWpO/ mFD5pqQqBNtgsadq7vPeIbcNR8Q7cGv8sFBxT+7ujsyZtttBSXYQh3+hCkQmN/98BzOD P7cO2Rqtw6ZutspQGvSHKNyR2iRffZI5jM5VNAzQr+Y5jK3AEIHja97eA0aKRmV7Sg87 aIDG5yvTKNIOr42u8wvuTwYIIW1wDIgOCwU5+44NeP3v45tj3wXCavitzms6vEuxXtAT Ly66v6oFsy+44c6oHqtM4mV4UhM/xOkKa5R0iDqL8JjXye9qz0ebGx02/CbdDs2RQ5xL olfg== X-Gm-Message-State: ACrzQf1+AZOkA1Sk0P0bAk5gbpKInhvjesdjzScM4oWDoR/atp9wbQBd y02LewbxJpv/TFzIRDnyIed8FXQZfE7eaw== X-Google-Smtp-Source: AMsMyM4itr+2Ipxo0hSi6ESJOXGaPvYia4F+z40sfL+6uusvTHsZiF9bFWl1BTOgHUrh5IA2WU92fQ== X-Received: by 2002:ac2:5dd5:0:b0:4a2:2960:a855 with SMTP id x21-20020ac25dd5000000b004a22960a855mr18201090lfq.399.1667809766713; Mon, 07 Nov 2022 00:29:26 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id a17-20020a056512201100b004a26b9cea32sm1114789lfb.271.2022.11.07.00.29.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 00:29:26 -0800 (PST) Message-ID: <334c5f69-2f25-aeb1-b87f-500cf2a6c205@linaro.org> Date: Mon, 7 Nov 2022 09:29:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] arm64: allwinner: a64: add device tree for SoPine with clusterboard Content-Language: en-US To: renze@rnplus.nl, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/11/2022 22:40, renze@rnplus.nl wrote: > The Pine64 clusterboard needs a to have the tx delay changed to > 500ps for ethernet to work. This solution was described by multiple > people on the Pine64 forum years ago and nobody has submitted it. > > Add a device tree for SoPine with the clusterboard. > > Signed-off-by: Renze Nicolai > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../dts/allwinner/sun50i-a64-sopine-clusterboard.dts | 10 ++++++++++ > 2 files changed, 11 insertions(+) > create mode 100644 > arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile > b/arch/arm64/boot/dts/allwinner/Makefile > index 6a96494a2e0a..15b011d1aaea 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += > sun50i-a64-pinephone-1.2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb This does not look like matching indentation of other entries... > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb > diff --git > a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > new file mode 100644 > index 000000000000..6f8020a22670 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > @@ -0,0 +1,10 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (c) 2022 Renze Nicolai > + > +/dts-v1/; > + > +#include "sun50i-a64-sopine-baseboard.dts" You miss compatible and model. You need to document the compatible in bindings (just like other top-level). > + > +&emac { > + allwinner,tx-delay-ps = <500>; > +}; Best regards, Krzysztof