* [PATCH] arm64: allwinner: a64: add device tree for SoPine with clusterboard @ 2022-11-06 21:40 renze 2022-11-07 8:29 ` Krzysztof Kozlowski 0 siblings, 1 reply; 5+ messages in thread From: renze @ 2022-11-06 21:40 UTC (permalink / raw) To: linux-sunxi, linux-kernel, linux-arm-kernel, devicetree Cc: Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland The Pine64 clusterboard needs a to have the tx delay changed to 500ps for ethernet to work. This solution was described by multiple people on the Pine64 forum years ago and nobody has submitted it. Add a device tree for SoPine with the clusterboard. Signed-off-by: Renze Nicolai <renze@rnplus.nl> --- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../dts/allwinner/sun50i-a64-sopine-clusterboard.dts | 10 ++++++++++ 2 files changed, 11 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile index 6a96494a2e0a..15b011d1aaea 100644 --- a/arch/arm64/boot/dts/allwinner/Makefile +++ b/arch/arm64/boot/dts/allwinner/Makefile @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file mode 100644 index 000000000000..6f8020a22670 --- /dev/null +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts @@ -0,0 +1,10 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (c) 2022 Renze Nicolai <renze@rnplus.nl> + +/dts-v1/; + +#include "sun50i-a64-sopine-baseboard.dts" + +&emac { + allwinner,tx-delay-ps = <500>; +}; -- 2.38.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: allwinner: a64: add device tree for SoPine with clusterboard 2022-11-06 21:40 [PATCH] arm64: allwinner: a64: add device tree for SoPine with clusterboard renze @ 2022-11-07 8:29 ` Krzysztof Kozlowski 2022-11-07 20:55 ` [PATCH v2] " Renze Nicolai 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2022-11-07 8:29 UTC (permalink / raw) To: renze, linux-sunxi, linux-kernel, linux-arm-kernel, devicetree Cc: Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland On 06/11/2022 22:40, renze@rnplus.nl wrote: > The Pine64 clusterboard needs a to have the tx delay changed to > 500ps for ethernet to work. This solution was described by multiple > people on the Pine64 forum years ago and nobody has submitted it. > > Add a device tree for SoPine with the clusterboard. > > Signed-off-by: Renze Nicolai <renze@rnplus.nl> > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../dts/allwinner/sun50i-a64-sopine-clusterboard.dts | 10 ++++++++++ > 2 files changed, 11 insertions(+) > create mode 100644 > arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile > b/arch/arm64/boot/dts/allwinner/Makefile > index 6a96494a2e0a..15b011d1aaea 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += > sun50i-a64-pinephone-1.2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb This does not look like matching indentation of other entries... > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb > diff --git > a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > new file mode 100644 > index 000000000000..6f8020a22670 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > @@ -0,0 +1,10 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (c) 2022 Renze Nicolai <renze@rnplus.nl> > + > +/dts-v1/; > + > +#include "sun50i-a64-sopine-baseboard.dts" You miss compatible and model. You need to document the compatible in bindings (just like other top-level). > + > +&emac { > + allwinner,tx-delay-ps = <500>; > +}; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] arm64: allwinner: a64: add device tree for SoPine with clusterboard 2022-11-07 8:29 ` Krzysztof Kozlowski @ 2022-11-07 20:55 ` Renze Nicolai 2022-11-07 21:39 ` Jernej Škrabec 2022-11-08 1:33 ` Icenowy Zheng 0 siblings, 2 replies; 5+ messages in thread From: Renze Nicolai @ 2022-11-07 20:55 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-sunxi, linux-kernel, linux-arm-kernel, devicetree, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland Hello Krzysztof, Thank you for your feedback! I've fixed the indentation and I've added the compatible and model elements. Greetings, Renze Nicolai The Pine64 clusterboard needs a to have the tx delay changed to 500ps for ethernet to work. This solution was described by multiple people on the Pine64 forum years ago and nobody has submitted it. Add a device tree for SoPine with the clusterboard. Signed-off-by: Renze Nicolai <renze@rnplus.nl> --- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../allwinner/sun50i-a64-sopine-clusterboard.dts | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile index 6a96494a2e0a..15b011d1aaea 100644 --- a/arch/arm64/boot/dts/allwinner/Makefile +++ b/arch/arm64/boot/dts/allwinner/Makefile @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts new file mode 100644 index 000000000000..f75325d43d76 --- /dev/null +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts @@ -0,0 +1,16 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (c) 2022 Renze Nicolai <renze@rnplus.nl> + +/dts-v1/; + +#include "sun50i-a64-sopine-baseboard.dts" + +/ { + model = "SoPine with clusterboard"; + compatible = "pine64,sopine-clusterboard", "pine64,sopine", + "allwinner,sun50i-a64"; +}; + +&emac { + allwinner,tx-delay-ps = <500>; +}; -- 2.38.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: allwinner: a64: add device tree for SoPine with clusterboard 2022-11-07 20:55 ` [PATCH v2] " Renze Nicolai @ 2022-11-07 21:39 ` Jernej Škrabec 2022-11-08 1:33 ` Icenowy Zheng 1 sibling, 0 replies; 5+ messages in thread From: Jernej Škrabec @ 2022-11-07 21:39 UTC (permalink / raw) To: Krzysztof Kozlowski, Renze Nicolai Cc: linux-sunxi, linux-kernel, linux-arm-kernel, devicetree, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai, Samuel Holland Dne ponedeljek, 07. november 2022 ob 21:55:04 CET je Renze Nicolai napisal(a): > Hello Krzysztof, > > Thank you for your feedback! I've fixed the indentation and I've added > the compatible and model elements. You didn't document compatible in bindings as instructed by Krzysztof. That should be in a patch preceding this one. Comments like this, which are not part of commit message, should be either in cover letter or right below --- line, so they are ignored when patch is applied. While above comment can be considered as changelog of sort, it's preferred to write it as list, point by point, in area which is ignored when applying patch. I guess you don't use "git send-email" to send your patches? New versions should not be send in reply to old ones. > > Greetings, > Renze Nicolai > > > The Pine64 clusterboard needs a to have the tx delay changed to > 500ps for ethernet to work. This solution was described by multiple > people on the Pine64 forum years ago and nobody has submitted it. When you're adding new board, commit message should describe new board either by stating features or telling which board is similar and what are the differences. Something like that clusterboard is almost the same as baseboard except ethernet TX delay, which is 500 ps. Omit second part of second statement, it's not relevant. Best regards, Jernej > > Add a device tree for SoPine with the clusterboard. > > Signed-off-by: Renze Nicolai <renze@rnplus.nl> > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-a64-sopine-clusterboard.dts | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+) > create mode 100644 > arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile > b/arch/arm64/boot/dts/allwinner/Makefile > index 6a96494a2e0a..15b011d1aaea 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += > sun50i-a64-pinephone-1.2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb > diff --git > a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > new file mode 100644 > index 000000000000..f75325d43d76 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (c) 2022 Renze Nicolai <renze@rnplus.nl> > + > +/dts-v1/; > + > +#include "sun50i-a64-sopine-baseboard.dts" > + > +/ { > + model = "SoPine with clusterboard"; > + compatible = "pine64,sopine-clusterboard", "pine64,sopine", > + "allwinner,sun50i-a64"; > +}; > + > +&emac { > + allwinner,tx-delay-ps = <500>; > +}; > -- > 2.38.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: allwinner: a64: add device tree for SoPine with clusterboard 2022-11-07 20:55 ` [PATCH v2] " Renze Nicolai 2022-11-07 21:39 ` Jernej Škrabec @ 2022-11-08 1:33 ` Icenowy Zheng 1 sibling, 0 replies; 5+ messages in thread From: Icenowy Zheng @ 2022-11-08 1:33 UTC (permalink / raw) To: Renze Nicolai, Krzysztof Kozlowski Cc: linux-sunxi, linux-kernel, linux-arm-kernel, devicetree, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland 在 2022-11-07星期一的 21:55 +0100，Renze Nicolai写道： > Hello Krzysztof, > > Thank you for your feedback! I've fixed the indentation and I've > added > the compatible and model elements. One small issue, I think the clusterboard has one node that comes with eMMC, which is different from other nodes. Should these have different DT's ? > > Greetings, > Renze Nicolai > > > The Pine64 clusterboard needs a to have the tx delay changed to > 500ps for ethernet to work. This solution was described by multiple > people on the Pine64 forum years ago and nobody has submitted it. > > Add a device tree for SoPine with the clusterboard. > > Signed-off-by: Renze Nicolai <renze@rnplus.nl> > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-a64-sopine-clusterboard.dts | 16 > ++++++++++++++++ > 2 files changed, 17 insertions(+) > create mode 100644 > arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile > b/arch/arm64/boot/dts/allwinner/Makefile > index 6a96494a2e0a..15b011d1aaea 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += > sun50i-a64-pinephone-1.2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb > diff --git > a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > new file mode 100644 > index 000000000000..f75325d43d76 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine- > clusterboard.dts > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (c) 2022 Renze Nicolai <renze@rnplus.nl> > + > +/dts-v1/; > + > +#include "sun50i-a64-sopine-baseboard.dts" > + > +/ { > + model = "SoPine with clusterboard"; > + compatible = "pine64,sopine-clusterboard", "pine64,sopine", > + "allwinner,sun50i-a64"; > +}; > + > +&emac { > + allwinner,tx-delay-ps = <500>; > +}; ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-08 1:34 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-11-06 21:40 [PATCH] arm64: allwinner: a64: add device tree for SoPine with clusterboard renze 2022-11-07 8:29 ` Krzysztof Kozlowski 2022-11-07 20:55 ` [PATCH v2] " Renze Nicolai 2022-11-07 21:39 ` Jernej Škrabec 2022-11-08 1:33 ` Icenowy Zheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).