From: Krzysztof Kozlowski <krzk@kernel.org>
To: Felix Kaechele <felix@kaechele.ca>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Kalle Valo <kvalo@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Rocky Liao <quic_rjliao@quicinc.com>
Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: net: bluetooth: qualcomm: add QCA9379 compatible
Date: Wed, 14 Aug 2024 08:14:28 +0200 [thread overview]
Message-ID: <3350aae1-a4a2-4a7c-a075-c29c8f67f5a2@kernel.org> (raw)
In-Reply-To: <3f16cd19-7609-4f97-bacd-9ab307bd8533@kaechele.ca>
On 14/08/2024 00:11, Felix Kaechele wrote:
> Thanks for taking a look, Krzysztof.
>
> In this case I think it would be easiest to just use the existing
> qca9377 fallback and drop his part of the patchset.
You need then other patchset documenting new compatible with fallback.
Compatibles are always specific.
https://elixir.bootlin.com/linux/v6.10-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst
>
> As for the supplies: For the particular module I am working with the
> supplies are mostly shared with the WiFi side. So it "just works"
> without taking care of supplies on the BT side.
You still should describe the hardware.
>
> But I agree it would be more correct to add and handle these as well.
> The documentation I have access to through the FCC filing of this module
> is not really conclusive of how to correctly name them in this context.
> I would rather avoid submitting a patch with incorrect supply names.
OK
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-14 6:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 4:01 [PATCH 0/4] Add support for QCA9379 hw1.0 SDIO WiFi/BT Felix Kaechele
2024-08-05 4:01 ` [PATCH 1/4] mmc: sdio: add Qualcomm QCA9379-3 SDIO id Felix Kaechele
2024-08-05 10:04 ` Ulf Hansson
2024-08-05 4:01 ` [PATCH 2/4] wifi: ath10k: add support for QCA9379 hw1.0 SDIO Felix Kaechele
2024-08-05 4:01 ` [PATCH 3/4] dt-bindings: net: bluetooth: qualcomm: add QCA9379 compatible Felix Kaechele
2024-08-05 5:31 ` Krzysztof Kozlowski
2024-08-13 22:11 ` Felix Kaechele
2024-08-14 6:14 ` Krzysztof Kozlowski [this message]
2024-08-05 4:01 ` [PATCH 4/4] Bluetooth: hci_qca: add compatible for QCA9379 Felix Kaechele
2024-08-05 5:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3350aae1-a4a2-4a7c-a075-c29c8f67f5a2@kernel.org \
--to=krzk@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=felix@kaechele.ca \
--cc=jjohnson@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).