Re: [PATCH V3 2/2] dt: Document sata_rcar bindings

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Kumar,

On Friday 08 November 2013 08:26:47 Kumar Gala wrote:
> On Nov 8, 2013, at 6:09 AM, Valentine Barshak wrote:
> > These bindings can be used to register SATA devices found on R-Car SoC.
> > 
> > Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
> > ---
> > Documentation/devicetree/bindings/ata/sata_rcar.txt | 18 +++++++++++++++++
> > 1 file changed, 18 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/ata/sata_rcar.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt
> > b/Documentation/devicetree/bindings/ata/sata_rcar.txt new file mode
> > 100644
> > index 0000000..1e61113
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt
> > @@ -0,0 +1,18 @@
> > +* Renesas R-Car SATA
> > +
> > +Required properties:
> > +- compatible		: should contain one of the following:
> > +			  - "renesas,sata-r8a7779" for R-Car H1
> > +			  - "renesas,sata-r8a7790" for R-Car H2
> > +			  - "renesas,sata-r8a7791" for R-Car M2
> > +- reg			: address and length of the SATA registers;
> > +- interrupts		: must consist of one interrupt specifier.
> > +
> > +Example:
> > +
> > +sata: sata@fc600000 {
> > +	compatible = "renesas,sata-r8a7779";
> > +	reg = <0xfc600000 0x2000>;
> > +	interrupt-parent = <&gic>;
> > +	interrupts = <0 100 IRQ_TYPE_LEVEL_HIGH>;
> 
> Sorry, I missed the discussion on this, but I think it would be better in
> the example to leave this as 4.  There is no reference in the binding at
> all to figure out where IRQ_TYPE_LEVEL_HIGH is defined.

Then I'd rather reference the interrupts binding document, otherwise people 
will blindly write device tree sources with 4 instead of IRQ_TYPE_LEVEL_HIGH, 
which I don't want to encourage.

> > +};
-- 
Regards,

Laurent Pinchart