Re: [PATCH v3 5/7] dt-bindings: mfd: Add synology,microp device

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/03/2026 21:29, Markus Probst wrote:
> 
>> This is not an "MFD" device.
> It now uses the MFD APIs. By the definiton of @Lee (assuming I
> understood it correctly), this device should now qualify as "MFD"
> device.

No. Using Linux framework does not make this device MFD, since there is
no such term of hardware as MFD. Otherwise please explain or link to
verifiable external source describing what sort of device class is MFD,
because for sure this is not MFD how Wikipedia defines it.

> 
>>> +
>>> +    mcu {
>>
>> Please read previous comments.
> 
> You are likly trying to refer to this comment from you:
>> Depending what this is. MCU is generic purpose unit where you load
> your
>> different FW for different purposes and you have here specific - to
>> handle certain aspects of this entire machine. This looks like EC, so
>> should be called embedded-controller and placed in that directory.
> Synology uses Microchip PIC for this purpose. On a Synology DS215j, it
> uses a "Microchip PIC16F1829". At least to me, this looks like a

It does not matter what chip is used. Every component uses some sort of
chip.

> general purpose microcontroller with firmware from synology flashed
> onto it. Therefore it is a MCU.

Every chip is then an MCU with such logic. Every PMIC, every EC.

This is for me clearly embedded controller and that's where this should
be placed and called.

Best regards,
Krzysztof