From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] media: i2c: add support for omnivision's ov2659 sensor Date: Thu, 05 Feb 2015 16:52:22 +0200 Message-ID: <3367184.gDmyGXufvA@avalon> References: <1421365163-29394-1-git-send-email-prabhakar.csengg@gmail.com> <3110055.vYzQi51GtK@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Lad, Prabhakar" Cc: LMML , "devicetree@vger.kernel.org" , LKML , Mauro Carvalho Chehab , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Sakari Ailus , Hans Verkuil , Benoit Parrot List-Id: devicetree@vger.kernel.org Hi Prabhakar, (CC'ing Benoit Parrot) On Thursday 05 February 2015 11:55:28 Lad, Prabhakar wrote: > On Thu, Feb 5, 2015 at 11:53 AM, Laurent Pinchart wrote: > > On Wednesday 04 February 2015 20:55:02 Lad, Prabhakar wrote: > >> On Wed, Feb 4, 2015 at 5:03 PM, Laurent Pinchart wrote: > >> > On Thursday 15 January 2015 23:39:23 Lad, Prabhakar wrote: > >> >> From: Benoit Parrot > >> >>=20 > >> >> this patch adds support for omnivision's ov2659 > >> >> sensor. > >> >>=20 > >> >> Signed-off-by: Benoit Parrot > >> >> Signed-off-by: Lad, Prabhakar > >> >> --- > >> >>=20 > >> >> .../devicetree/bindings/media/i2c/ov2659.txt | 33 + > >> >> .../devicetree/bindings/vendor-prefixes.txt | 1 + > >> >> MAINTAINERS | 10 + > >> >> drivers/media/i2c/Kconfig | 11 + > >> >> drivers/media/i2c/Makefile | 1 + > >> >> drivers/media/i2c/ov2659.c | 1623 ++++= +++++++ > >> >> include/media/ov2659.h | 33 + > >> >> 7 files changed, 1712 insertions(+) > >> >> create mode 100644 > >> >> Documentation/devicetree/bindings/media/i2c/ov2659.txt > >> >> create mode 100644 drivers/media/i2c/ov2659.c > >> >> create mode 100644 include/media/ov2659.h > >=20 > > [snip] > >=20 > >> >> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2= 659.c > >> >> new file mode 100644 > >> >> index 0000000..ce8ec8d > >> >> --- /dev/null > >> >> +++ b/drivers/media/i2c/ov2659.c > >> >> @@ -0,0 +1,1623 @@ > >=20 > > [snip] > >=20 > >> >> +static const struct ov2659_framesize ov2659_framesizes[] =3D { > >> >> + { /* QVGA */ > >> >> + .width =3D 320, > >> >> + .height =3D 240, > >> >> + .regs =3D ov2659_qvga, > >> >> + .max_exp_lines =3D 248, > >> >> + }, { /* VGA */ > >> >> + .width =3D 640, > >> >> + .height =3D 480, > >> >> + .regs =3D ov2659_vga, > >> >> + .max_exp_lines =3D 498, > >> >> + }, { /* SVGA */ > >> >> + .width =3D 800, > >> >> + .height =3D 600, > >> >> + .regs =3D ov2659_svga, > >> >> + .max_exp_lines =3D 498, > >> >> + }, { /* XGA */ > >> >> + .width =3D 1024, > >> >> + .height =3D 768, > >> >> + .regs =3D ov2659_xga, > >> >> + .max_exp_lines =3D 498, > >> >> + }, { /* 720P */ > >> >> + .width =3D 1280, > >> >> + .height =3D 720, > >> >> + .regs =3D ov2659_720p, > >> >> + .max_exp_lines =3D 498, > >> >> + }, { /* SXGA */ > >> >> + .width =3D 1280, > >> >> + .height =3D 1024, > >> >> + .regs =3D ov2659_sxga, > >> >> + .max_exp_lines =3D 1048, > >> >> + }, { /* UXGA */ > >> >> + .width =3D 1600, > >> >> + .height =3D 1200, > >> >> + .regs =3D ov2659_uxga, > >> >> + .max_exp_lines =3D 498, > >> >> + }, > >> >> +}; > >> >=20 > >> > That's what bothers me the most about drivers for Omnivision sen= sors. > >> > For some reason (I'd bet on lack of proper documentation) they l= ist a > >> > couple of supported resolutions with corresponding register valu= es, > >> > instead of computing the register values from the format configu= red by > >> > userspace. That's not the way we want to go. Prabhakar, do you h= ave > >> > enough documentation to fix that ? > >>=20 > >> I am afraid I have limited documentation here. > >=20 > > How limited ? :-) I assume someone has documentation, given that th= e patch > > contains a larger number of #define's with register names. >=20 > Yea I don=E2=80=99t have NDA signed with TI/Omnivision :( because I w= hich I > lack the documentation. And a quick online search doesn't show any leaked datasheet. Wikileaks = isn't=20 doing a good job ;-) Benoit, do you think this is something that can be fixed ? --=20 Regards, Laurent Pinchart