From: Matthias Brugger <mbrugger@suse.com>
To: Lee Jones <lee@kernel.org>, matthias.bgg@kernel.org
Cc: robh+dt@kernel.org, angelogioacchino.delregno@collabora.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
mandyjh.liu@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml
Date: Tue, 13 Sep 2022 13:51:47 +0200 [thread overview]
Message-ID: <336cb80f-8f58-92ba-aa92-1bb57a75f0fb@suse.com> (raw)
In-Reply-To: <YxnGBN4QEb1yMrGw@google.com>
On 08/09/2022 12:37, Lee Jones wrote:
> On Tue, 30 Aug 2022, matthias.bgg@kernel.org wrote:
>
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> The file describes the scpsys node for all SoCs and not only the mt8195.
>> Rename it to reflect this fact.
>
> Actually, this is fairly typical. Same with actual drivers.
>
> Both tend to adopt the name of the module first supported.
>
Well I think that's unfortunate as it can create confusion for people searching
for the binding as well as people adding a new compatible as they might think
each SoC should have a independent yaml file. For that I reason I think it makes
sense to fix the naming.
Regards,
Matthias
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
>> ---
>>
>> Changes in v2:
>> - Fix id
>>
>> .../mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> rename Documentation/devicetree/bindings/mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} (96%)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>> similarity index 96%
>> rename from Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
>> rename to Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>> index 3737207d8504..1a5901ca90f5 100644
>> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>> @@ -1,7 +1,7 @@
>> # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> %YAML 1.2
>> ---
>> -$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml#
>> +$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml#
>> $schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>> title: MediaTek System Control Processor System
>
next prev parent reply other threads:[~2022-09-13 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 9:11 [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml matthias.bgg
2022-09-06 16:41 ` Rob Herring
2022-09-08 10:37 ` Lee Jones
2022-09-13 11:51 ` Matthias Brugger [this message]
2022-09-20 9:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=336cb80f-8f58-92ba-aa92-1bb57a75f0fb@suse.com \
--to=mbrugger@suse.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mandyjh.liu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).