devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: djw@t-chip.com.cn
Cc: linux-rockchip@lists.infradead.org,
	Wayne Chou <zxf@t-chip.com.cn>,
	devicetree@vger.kernel.org, David Wu <david.wu@rock-chips.com>,
	Liang Chen <cl@rock-chips.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Rocky Hao <rocky.hao@rock-chips.com>,
	Will Deacon <will.deacon@arm.com>,
	Joseph Chen <chenjh@rock-chips.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 4/4] arm64: dts: rockchip: add sdmmc UHS support for roc-rk3328-cc
Date: Sat, 04 Aug 2018 15:18:32 +0200	[thread overview]
Message-ID: <3379811.jaOMd9KUxU@phil> (raw)
In-Reply-To: <1533016762-5268-5-git-send-email-djw@t-chip.com.cn>

Hi Levin,

Am Dienstag, 31. Juli 2018, 07:59:22 CEST schrieb djw@t-chip.com.cn:
> From: Levin Du <djw@t-chip.com.cn>
> 
> In roc-rk3328-cc board, the signal voltage of sdmmc is supplied by the
> vcc_sdio regulator, which is a mux between 1.8V and 3.3V, controlled by
> a special output only gpio pin labeled "gpiomut_pmuio_iout",
> corresponding bit 1 of the syscon GRF_SOC_CON10.
> 
> This special pin can now be reference as <&grf_gpio 0>, thanks to the
> gpio-syscon driver, which makes writing regulator-gpio possible.
> 
> If the signal voltage changes, the io domain needs to change
> correspondingly.
> 
> To use this feature, the following options are required in kernel config:
>  - CONFIG_GPIO_SYSCON=y
>  - CONFIG_POWER_AVS=y
>  - CONFIG_ROCKCHIP_IODOMAIN=y
> 
> Signed-off-by: Levin Du <djw@t-chip.com.cn>

[...]

> @@ -277,3 +295,7 @@
>  &usb_host0_ohci {
>  	status = "okay";
>  };
> +
> +&grf_gpio {
> +	status = "okay";
> +};
> 

applied to my dts64 branch after dropping the grf_gpio enablement,
see comment in patch2 regarding the always present pin.


Thanks
Heiko

      reply	other threads:[~2018-08-04 13:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31  5:59 [PATCH v4 0/4] Add sdmmc UHS support to ROC-RK3328-CC board djw
2018-07-31  5:59 ` [PATCH v4 1/4] gpio: syscon: rockchip: add GRF GPIO support for rk3328 djw
2018-07-31 19:36   ` Rob Herring
2018-08-01 11:46   ` Heiko Stuebner
2018-08-03 17:13   ` Linus Walleij
2018-07-31  5:59 ` [PATCH v4 2/4] arm64: dts: rockchip: add GRF GPIO controller to rk3328 djw
2018-08-04 13:16   ` Heiko Stuebner
2018-07-31  5:59 ` [PATCH v4 3/4] arm64: dts: rockchip: add io-domain to roc-rk3328-cc djw
2018-08-02 12:54   ` Heiko Stuebner
2018-07-31  5:59 ` [PATCH v4 4/4] arm64: dts: rockchip: add sdmmc UHS support for roc-rk3328-cc djw
2018-08-04 13:18   ` Heiko Stuebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3379811.jaOMd9KUxU@phil \
    --to=heiko@sntech.de \
    --cc=catalin.marinas@arm.com \
    --cc=chenjh@rock-chips.com \
    --cc=cl@rock-chips.com \
    --cc=david.wu@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djw@t-chip.com.cn \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rocky.hao@rock-chips.com \
    --cc=will.deacon@arm.com \
    --cc=zxf@t-chip.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).