From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>,
agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
wim@linux-watchdog.org, linux@roeck-us.net
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
manivannan.sadhasivam@linaro.org
Subject: Re: [PATCH 08/11] ARM: dts: qcom: sdx65-mtp: Increase the vmalloc size
Date: Wed, 1 Jun 2022 13:06:02 +0200 [thread overview]
Message-ID: <3389a816-0f51-ab83-1026-2201017a2f12@linaro.org> (raw)
In-Reply-To: <1654080312-5408-9-git-send-email-quic_rohiagar@quicinc.com>
On 01/06/2022 12:45, Rohit Agarwal wrote:
> Increase the size of vmalloc using the bootargs in sdx65
> mtp board.
> It is failing to alloacte the size needed for firmware and
> giving the error logs due to actual vmalloc region lesser than requested.
>
> cat /proc/meminfo shows the size of VmallocTotal as 245760 kB.
>
> [ 10.980356] vmap allocation for size 268439552 failed: use vmalloc=<size> to increase size
> [ 10.980505] qcom_q6v5_pas 4080000.remoteproc: unable to map memory region: 0x90800000+10000000
> [ 10.988542] In adsp alloc memory: adsp_probe 482
> [ 10.988592] remoteproc remoteproc0: releasing 4080000.remoteproc
> [ 11.001598] qcom_q6v5_pas: probe of 4080000.remoteproc failed with error -16
>
> Thus, increasing the size to 300000000 as modem is not the only one using vmalloc region.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> arch/arm/boot/dts/qcom-sdx65-mtp.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> index 85ea02d..966385f 100644
> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> @@ -21,6 +21,7 @@
>
> chosen {
> stdout-path = "serial0:115200n8";
> + bootargs = "vmalloc=300000000";
I understand that issue comes from SoC-related driver but this is not a
property of the hardware. This could be added by bootloader if needed,
but in regular case this is a system setup parameter, so it does not
belong to DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-01 11:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 10:45 [PATCH 00/11] Devicetree Changes SDX65 Rohit Agarwal
2022-06-01 10:45 ` [PATCH 01/11] ARM: dts: qcom: sdx65: Add CPUFreq support Rohit Agarwal
2022-06-01 10:45 ` [PATCH 02/11] ARM: dts: qcom: sdx65: Add modem SMP2P node Rohit Agarwal
2022-06-01 10:45 ` [PATCH 03/11] ARM: dts: qcom: sdx65: Add IMEM and PIL info region Rohit Agarwal
2022-06-01 10:45 ` [PATCH 04/11] dt-bindings: firmware: scm: Add compatible for SDX65 Rohit Agarwal
2022-06-01 11:01 ` Krzysztof Kozlowski
2022-06-28 20:19 ` (subset) " Bjorn Andersson
2022-06-01 10:45 ` [PATCH 05/11] ARM: dts: qcom: sdx65: Add SCM node Rohit Agarwal
2022-06-01 10:45 ` [PATCH 06/11] ARM: dts: qcom: sdx65: Add Modem remoteproc node Rohit Agarwal
2022-06-01 10:45 ` [PATCH 07/11] ARM: dts: qcom: sdx65-mtp: Enable modem Rohit Agarwal
2022-06-01 10:45 ` [PATCH 08/11] ARM: dts: qcom: sdx65-mtp: Increase the vmalloc size Rohit Agarwal
2022-06-01 11:06 ` Krzysztof Kozlowski [this message]
2022-06-01 10:45 ` [PATCH 09/11] dt-bindings: watchdog: Add binding for Qcom SDX65 Rohit Agarwal
2022-06-01 11:02 ` Krzysztof Kozlowski
2022-06-01 13:53 ` Guenter Roeck
2022-06-01 10:45 ` [PATCH 10/11] ARM: dts: qcom: sdx65: Add Watchdog support Rohit Agarwal
2022-06-01 11:03 ` Krzysztof Kozlowski
2022-06-28 20:19 ` (subset) " Bjorn Andersson
2022-06-01 10:45 ` [PATCH 11/11] ARM: dts: qcom: sdx65: Add pshold support Rohit Agarwal
2022-06-28 20:19 ` (subset) [PATCH 00/11] Devicetree Changes SDX65 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3389a816-0f51-ab83-1026-2201017a2f12@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_rohiagar@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).