public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Fix reserved-memory issues to enable IPA
@ 2025-12-08  3:15 Jingzhou Zhu
  2025-12-08  3:15 ` [PATCH 1/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate reserved-memroy nodes Jingzhou Zhu
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Jingzhou Zhu @ 2025-12-08  3:15 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel, Jingzhou Zhu

In newer kernels, the reserved-memory hinders some drivers (SLPI and
IPA) to load. Correct some of the nodes to address this problem.

Jingzhou Zhu (2):
  arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate
    reserved-memroy nodes
  arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem
    for the driver to load successfully

 .../dts/qcom/sdm850-huawei-matebook-e-2019.dts  | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

-- 
2.47.3


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate reserved-memroy nodes
  2025-12-08  3:15 [PATCH 0/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Fix reserved-memory issues to enable IPA Jingzhou Zhu
@ 2025-12-08  3:15 ` Jingzhou Zhu
  2025-12-09 23:05   ` Dmitry Baryshkov
  2025-12-08  3:15 ` [PATCH 2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem for the driver to load successfully Jingzhou Zhu
  2026-01-05 14:07 ` [PATCH 0/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Fix reserved-memory issues to enable IPA Bjorn Andersson
  2 siblings, 1 reply; 7+ messages in thread
From: Jingzhou Zhu @ 2025-12-08  3:15 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel, Jingzhou Zhu

The adsp_mem and slpi_mem defined in sdm845.dtsi work well. Remove these
nodes here to avoid redefinition.

Signed-off-by: Jingzhou Zhu <newwheatzjz@zohomail.com>
---
 .../boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts   | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
index 0ef9ea38a424..a5f025ae7dbe 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
@@ -30,9 +30,7 @@
 /delete-node/ &ipa_fw_mem;
 /delete-node/ &ipa_gsi_mem;
 /delete-node/ &gpu_mem;
-/delete-node/ &adsp_mem;
 /delete-node/ &wlan_msa_mem;
-/delete-node/ &slpi_mem;
 
 / {
 	model = "Huawei MateBook E 2019";
@@ -145,20 +143,11 @@ wlan_msa_mem: wlan-msa@8c400000 {
 			no-map;
 		};
 
-		adsp_mem: adsp@8c500000 {
-			reg = <0 0x8c500000 0 0x1a00000>;
-			no-map;
-		};
-
 		ipa_fw_mem: ipa-fw@8df00000 {
 			reg = <0 0x8df00000 0 0x100000>;
 			no-map;
 		};
 
-		slpi_mem: slpi@96700000 {
-			reg = <0 0x96700000 0 0x1200000>;
-		};
-
 		gpu_mem: gpu@97900000 {
 			reg = <0 0x97900000 0 0x5000>;
 			no-map;
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem for the driver to load successfully
  2025-12-08  3:15 [PATCH 0/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Fix reserved-memory issues to enable IPA Jingzhou Zhu
  2025-12-08  3:15 ` [PATCH 1/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate reserved-memroy nodes Jingzhou Zhu
@ 2025-12-08  3:15 ` Jingzhou Zhu
  2025-12-09 23:08   ` Dmitry Baryshkov
  2026-01-05 14:07 ` [PATCH 0/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Fix reserved-memory issues to enable IPA Bjorn Andersson
  2 siblings, 1 reply; 7+ messages in thread
From: Jingzhou Zhu @ 2025-12-08  3:15 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel, Jingzhou Zhu

The ipa driver refuses to load with the old ipa_fw_mem in newer kernels.
Shrinking its size to 0x5a000 fixes the problem.

Fixes: aab69794b55d ("arm64: dts: qcom: Add support for Huawei MateBook E 2019")

Signed-off-by: Jingzhou Zhu <newwheatzjz@zohomail.com>
---
 arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
index a5f025ae7dbe..f04865381870 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
@@ -144,12 +144,12 @@ wlan_msa_mem: wlan-msa@8c400000 {
 		};
 
 		ipa_fw_mem: ipa-fw@8df00000 {
-			reg = <0 0x8df00000 0 0x100000>;
+			reg = <0 0x8df00000 0 0x5a000>;
 			no-map;
 		};
 
-		gpu_mem: gpu@97900000 {
-			reg = <0 0x97900000 0 0x5000>;
+		gpu_mem: gpu@8df5a000 {
+			reg = <0 0x8df5a000 0 0x5000>;
 			no-map;
 		};
 
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate reserved-memroy nodes
  2025-12-08  3:15 ` [PATCH 1/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate reserved-memroy nodes Jingzhou Zhu
@ 2025-12-09 23:05   ` Dmitry Baryshkov
  0 siblings, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2025-12-09 23:05 UTC (permalink / raw)
  To: Jingzhou Zhu
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel

On Mon, Dec 08, 2025 at 11:15:10AM +0800, Jingzhou Zhu wrote:
> The adsp_mem and slpi_mem defined in sdm845.dtsi work well. Remove these
> nodes here to avoid redefinition.
> 
> Signed-off-by: Jingzhou Zhu <newwheatzjz@zohomail.com>
> ---
>  .../boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts   | 11 -----------
>  1 file changed, 11 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem for the driver to load successfully
  2025-12-08  3:15 ` [PATCH 2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem for the driver to load successfully Jingzhou Zhu
@ 2025-12-09 23:08   ` Dmitry Baryshkov
  2025-12-10  2:41     ` Jingzhou Zhu
  0 siblings, 1 reply; 7+ messages in thread
From: Dmitry Baryshkov @ 2025-12-09 23:08 UTC (permalink / raw)
  To: Jingzhou Zhu
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel

On Mon, Dec 08, 2025 at 11:15:11AM +0800, Jingzhou Zhu wrote:
> The ipa driver refuses to load with the old ipa_fw_mem in newer kernels.
> Shrinking its size to 0x5a000 fixes the problem.
> 
> Fixes: aab69794b55d ("arm64: dts: qcom: Add support for Huawei MateBook E 2019")
> 
> Signed-off-by: Jingzhou Zhu <newwheatzjz@zohomail.com>

There should be no empty lines between tags.

> ---
>  arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
> index a5f025ae7dbe..f04865381870 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
> @@ -144,12 +144,12 @@ wlan_msa_mem: wlan-msa@8c400000 {
>  		};
>  
>  		ipa_fw_mem: ipa-fw@8df00000 {
> -			reg = <0 0x8df00000 0 0x100000>;
> +			reg = <0 0x8df00000 0 0x5a000>;
>  			no-map;
>  		};
>  
> -		gpu_mem: gpu@97900000 {
> -			reg = <0 0x97900000 0 0x5000>;
> +		gpu_mem: gpu@8df5a000 {

Why are you adjusting gpu_mem?

> +			reg = <0 0x8df5a000 0 0x5000>;
>  			no-map;
>  		};
>  
> -- 
> 2.47.3
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem for the driver to load successfully
  2025-12-09 23:08   ` Dmitry Baryshkov
@ 2025-12-10  2:41     ` Jingzhou Zhu
  0 siblings, 0 replies; 7+ messages in thread
From: Jingzhou Zhu @ 2025-12-10  2:41 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel

On Wednesday, 10 December 2025 07:08:41 CST, Dmitry Baryshkov wrote:
> On Mon, Dec 08, 2025 at 11:15:11AM +0800, Jingzhou Zhu wrote:
> > The ipa driver refuses to load with the old ipa_fw_mem in newer kernels.
> > Shrinking its size to 0x5a000 fixes the problem.
> > 
> > Fixes: aab69794b55d ("arm64: dts: qcom: Add support for Huawei MateBook E 2019")
> > 
> > Signed-off-by: Jingzhou Zhu <newwheatzjz@zohomail.com>
> 
> There should be no empty lines between tags.
> 

Understood.

> > ---
> >  arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
> > index a5f025ae7dbe..f04865381870 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
> > @@ -144,12 +144,12 @@ wlan_msa_mem: wlan-msa@8c400000 {
> >  		};
> >  
> >  		ipa_fw_mem: ipa-fw@8df00000 {
> > -			reg = <0 0x8df00000 0 0x100000>;
> > +			reg = <0 0x8df00000 0 0x5a000>;
> >  			no-map;
> >  		};
> >  
> > -		gpu_mem: gpu@97900000 {
> > -			reg = <0 0x97900000 0 0x5000>;
> > +		gpu_mem: gpu@8df5a000 {
> 
> Why are you adjusting gpu_mem?
> 

In sdm845.dtsi, ipa_fw_mem is followed by gpu_mem, so I moved gpu_mem to
0x8df5a000 since the memory was freed after shrinking ipa_fw_mem size.
I'm not sure whether the order matters, but I think it's best to follow
how they are arranged in sdm845.dtsi.

Also, this change didn't seem to cause problems according to my testing.

> > +			reg = <0 0x8df5a000 0 0x5000>;
> >  			no-map;
> >  		};
> >  
> 
> 





^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Fix reserved-memory issues to enable IPA
  2025-12-08  3:15 [PATCH 0/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Fix reserved-memory issues to enable IPA Jingzhou Zhu
  2025-12-08  3:15 ` [PATCH 1/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate reserved-memroy nodes Jingzhou Zhu
  2025-12-08  3:15 ` [PATCH 2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem for the driver to load successfully Jingzhou Zhu
@ 2026-01-05 14:07 ` Bjorn Andersson
  2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2026-01-05 14:07 UTC (permalink / raw)
  To: konradybcio, robh, krzk+dt, conor+dt, Jingzhou Zhu
  Cc: linux-arm-msm, devicetree, linux-kernel


On Mon, 08 Dec 2025 11:15:09 +0800, Jingzhou Zhu wrote:
> In newer kernels, the reserved-memory hinders some drivers (SLPI and
> IPA) to load. Correct some of the nodes to address this problem.
> 
> Jingzhou Zhu (2):
>   arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate
>     reserved-memroy nodes
>   arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem
>     for the driver to load successfully
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate reserved-memroy nodes
      commit: a499c40ccd8e748ef363e2d13fb7a5c0ed6a788a
[2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem for the driver to load successfully
      commit: bc11f6f1d2470fa59846be077555f9d4b7c2c0d3

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-01-05 14:08 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-08  3:15 [PATCH 0/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Fix reserved-memory issues to enable IPA Jingzhou Zhu
2025-12-08  3:15 ` [PATCH 1/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Remove duplicate reserved-memroy nodes Jingzhou Zhu
2025-12-09 23:05   ` Dmitry Baryshkov
2025-12-08  3:15 ` [PATCH 2/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Correct ipa_fw_mem for the driver to load successfully Jingzhou Zhu
2025-12-09 23:08   ` Dmitry Baryshkov
2025-12-10  2:41     ` Jingzhou Zhu
2026-01-05 14:07 ` [PATCH 0/2] arm64: dts: qcom: sdm850-huawei-matebook-e-2019: Fix reserved-memory issues to enable IPA Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox