From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 1/2] usb: dwc3: core: add support for RTK SoC custom's global register start address
Date: Thu, 4 May 2023 03:28:53 +0000 [thread overview]
Message-ID: <3393bfb7d9284242ad95ca350558abd9@realtek.com> (raw)
In-Reply-To: <20230503223704.c3kccy74o7h3iawx@synopsys.com>
Hi Thinh,
> > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index
> > d56457c02996..db48aae211be 100644
> > --- a/drivers/usb/dwc3/core.h
> > +++ b/drivers/usb/dwc3/core.h
> > @@ -84,6 +84,8 @@
> > #define DWC3_OTG_REGS_START 0xcc00
> > #define DWC3_OTG_REGS_END 0xccff
> >
> > +#define RTK_RTD1XXX_DWC3_GLOBALS_REGS_START 0x8100
>
> Let's keep consistent with the DWC3_ prefix. Something like this:
>
> #define DWC3_RTK_RTD1XXX_GLOBAL_REGS_START 0x8100
Okay. I will revise it.
Thanks,
Stanley
prev parent reply other threads:[~2023-05-04 3:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 5:04 [PATCH v4 1/2] usb: dwc3: core: add support for RTK SoC custom's global register start address Stanley Chang
2023-05-02 5:04 ` [PATCH v4 2/2] dt-bindings: usb: snps,dwc3: Add the compatible name 'snps,dwc3-rtk-soc' Stanley Chang
2023-05-02 7:40 ` Krzysztof Kozlowski
2023-05-02 8:05 ` Stanley Chang[昌育德]
2023-05-02 8:44 ` Krzysztof Kozlowski
2023-05-02 8:56 ` Stanley Chang[昌育德]
2023-05-02 10:15 ` Krzysztof Kozlowski
2023-05-02 10:37 ` Stanley Chang[昌育德]
2023-05-02 19:27 ` Krzysztof Kozlowski
2023-05-03 3:14 ` Stanley Chang[昌育德]
2023-05-02 22:36 ` [PATCH v4 1/2] usb: dwc3: core: add support for RTK SoC custom's global register start address Thinh Nguyen
2023-05-02 22:39 ` Thinh Nguyen
2023-05-03 3:08 ` Stanley Chang[昌育德]
2023-05-03 22:37 ` Thinh Nguyen
2023-05-04 3:28 ` Stanley Chang[昌育德] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3393bfb7d9284242ad95ca350558abd9@realtek.com \
--to=stanley_chang@realtek.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).