From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F637C4332F for ; Tue, 29 Nov 2022 07:50:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbiK2HuN (ORCPT ); Tue, 29 Nov 2022 02:50:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbiK2Htx (ORCPT ); Tue, 29 Nov 2022 02:49:53 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E57352147 for ; Mon, 28 Nov 2022 23:49:52 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id r12so21252502lfp.1 for ; Mon, 28 Nov 2022 23:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z7AuujM8+aeCGquyh830lAMw8HGWJigyKqEFa19drNo=; b=JnFA7pQpspbBCPizM4zXsJ2NveZL9iZ/llMZEhzqu7vCVdKlZ4PTn0pq+bfzFkzg3d IS+b2xLwuCS21piN8BlNpd06VA8M0S+7CWR+R03IecplidnP28JkUyt/g5WTgwoVvXgp tuvDxCox7+cWHOihucgZ6qTF6VvdamNeBjQMJD+jm7UorwcUWlwzviKR9GAi0QvrceHA lHdNl7TIkKuZpiArMc5X4ctiMD+OPvyLTuv99KbfY4YZNda7oAChMjuMqxfcEozTZ2Bi 8R1MlDP5ueTcz8zha7imXyQ9ssyQcYvwyM90VP75nW1FfeN120UmNvovCs46BNksfKZ7 DGxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z7AuujM8+aeCGquyh830lAMw8HGWJigyKqEFa19drNo=; b=BG9en/WFJiRNMANcvbzJ0aFA6n+6pWV6vH8EbqqBbamy1tCAgfRZy7omLM8WQHM/7e 1auKphsdT0kwvDiZcb5C9oEvy2dwrZHaQEKtrhEbzufHxI7YGmwGC+0epizEUI1tCt8R LA8vIn0nuv6PxhEWDWuu2iB6l/1P/A96JNpnngdlvF8hxJvDOaJQhnmdSyqhdbmGmNHk oJQjrUSyIeDz68QuYFNbYaJL5GO3OZgQiaIqPfWyy+Nix0Qqn5cMCnr9/1NdCMAAk1A/ uA0maI1gvEtYvtItaPwD5lztVDx4EAUdcBahXHUsJGOMLkNXDkNNz+2onxCMrfy6G2Z9 PkqQ== X-Gm-Message-State: ANoB5plKdT/yNWr6QEStyNxQeSRvpGjbvSEGIZw7vuEqhg0NaoWI+dBs MDE6Eb7PDRgudvPZLrdHddmwIw== X-Google-Smtp-Source: AA0mqf64LWlV5ymRt0Y4uGdG28tz9Pfe50jqdaNDybjAyLGTK+WsiZup0t4YfLvpdkzBf8U5SobnWA== X-Received: by 2002:a19:7708:0:b0:4a2:6b44:d742 with SMTP id s8-20020a197708000000b004a26b44d742mr20417340lfc.191.1669708190485; Mon, 28 Nov 2022 23:49:50 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w9-20020a05651234c900b004b4823f02b0sm2084055lfr.152.2022.11.28.23.49.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 23:49:50 -0800 (PST) Message-ID: <339be655-aee7-e1a4-51be-28ea20de6792@linaro.org> Date: Tue, 29 Nov 2022 08:49:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 1/5] dt-bindings: pinctrl: Add StarFive JH7110 pinctrl definitions Content-Language: en-US To: Jianlong Huang , Hal Feng , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Cc: Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Linus Walleij , Emil Renner Berthing , linux-kernel@vger.kernel.org References: <20221118011108.70715-1-hal.feng@starfivetech.com> <20221118011108.70715-2-hal.feng@starfivetech.com> <08db0f3b-5222-9460-26ba-0e6380d16583@linaro.org> <0ceba170-f844-e733-a49e-e67746f9f836@starfivetech.com> <093ea507-4c42-1af9-4896-64c1a918432e@linaro.org> <30c21787-0c48-ff50-1d63-8e69bdcdbe30@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <30c21787-0c48-ff50-1d63-8e69bdcdbe30@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/11/2022 02:47, Jianlong Huang wrote: > On Mon, 28 Nov 2022 09:32:45 +0100, Krzysztof Kozlowski wrote: >> On 28/11/2022 01:48, Jianlong Huang wrote: >> >>>>>> +/* aon_iomux doen */ >>>>>> +#define GPOEN_AON_PTC0_OE_N_4 2 >>>>>> +#define GPOEN_AON_PTC0_OE_N_5 3 >>>>>> +#define GPOEN_AON_PTC0_OE_N_6 4 >>>>>> +#define GPOEN_AON_PTC0_OE_N_7 5 >>>>>> + >>>>> >>>>> It looks like you add register constants to the bindings. Why? The >>>>> bindings are not the place to represent hardware programming model. Not >>>>> mentioning that there is no benefit in this. >>>> >>>> Also: this entire file should be dropped, but if it stays, you have to >>>> name it matching bindings or compatible (vendor,device.h). >>> >>> Thanks your comments. >>> These macros are used to configure pinctrl in dts, so the file should stay, >> >> Why they should stay? What's the reason? If it is not a constant used by >> driver, then register values should not be placed in the bindings, so >> drop it. >> > > Thanks. > > These macros in binding header(example, DOUT, DOEN etc) will be used in DTS, > and driver will parse the DT for pinctrl configuration. > > Example in dts: > uart0_pins: uart0-0 { > tx-pins { > pinmux = ; This is usage in DTS and is not an argument to store register addresses/offsets as bindings. What is the usage (of define, not value) in the driver? Best regards, Krzysztof