From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Iskren Chernev <iskren.chernev@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/14] arm64: dts: qcom: sm6115: Add sdhci nodes and related pinctrl
Date: Thu, 1 Sep 2022 19:08:20 +0300 [thread overview]
Message-ID: <339df7b9-bc7d-039d-99d8-ecdd480419d8@linaro.org> (raw)
In-Reply-To: <20220901072414.1923075-8-iskren.chernev@gmail.com>
On 01/09/2022 10:24, Iskren Chernev wrote:
> Add support for the two sdhci's present on the SM6115 and the related
> pinctrl.
>
>
> gcc: clock-controller@1400000 {
> @@ -449,6 +553,73 @@ rpm_msg_ram: memory@45f0000 {
> reg = <0x45f0000 0x7000>;
> };
>
> + sdhc_1: sdhci@4744000 {
> + compatible = "qcom,sm6115-sdhci", "qcom,sdhci-msm-v5";
> + reg = <0x4744000 0x1000>, <0x4745000 0x1000>, <0x4748000 0x8000>;
> + reg-names = "hc", "cqhci", "ice";
> +
> + interrupts = <GIC_SPI 348 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "hc_irq", "pwr_irq";
> +
> + clocks = <&gcc GCC_SDCC1_AHB_CLK>,
> + <&gcc GCC_SDCC1_APPS_CLK>,
> + <&xo_board>,
> + <&gcc GCC_SDCC1_ICE_CORE_CLK>;
> + clock-names = "iface", "core", "xo", "ice_core_clk";
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-01 16:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 7:23 [PATCH 00/14] Add support for sm6115,4250 and OnePlus Nord N100 Iskren Chernev
2022-09-01 7:24 ` [PATCH 01/14] arm64: dts: qcom: sm6115: Add basic soc dtsi Iskren Chernev
2022-09-01 16:03 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 02/14] arm64: dts: qcom: sm6115: Add rpmcc and rpmpd nodes Iskren Chernev
2022-09-01 7:24 ` [PATCH 03/14] arm64: dts: qcom: sm6115: Add GCC node Iskren Chernev
2022-09-01 16:05 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 04/14] arm64: dts: qcom: sm6115: Add pinctrl node Iskren Chernev
2022-09-01 7:24 ` [PATCH 05/14] arm64: dts: qcom: sm6115: Add apps smmu node Iskren Chernev
2022-09-01 16:05 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 06/14] arm64: dts: qcom: sm6115: Add usb and related phy nodes Iskren Chernev
2022-09-01 16:06 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 07/14] arm64: dts: qcom: sm6115: Add sdhci nodes and related pinctrl Iskren Chernev
2022-09-01 16:08 ` Krzysztof Kozlowski [this message]
2022-09-01 7:24 ` [PATCH 08/14] dt-bindings: ufs: qcom: Add sm6115 binding Iskren Chernev
2022-09-01 16:11 ` Krzysztof Kozlowski
2022-09-03 16:54 ` Iskren Chernev
2022-09-04 19:10 ` Krzysztof Kozlowski
2022-09-05 7:29 ` Iskren Chernev
2022-09-05 10:03 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 09/14] arm64: dts: qcom: sm6115: Add UFS nodes Iskren Chernev
2022-09-01 16:13 ` Krzysztof Kozlowski
2022-09-03 17:04 ` Iskren Chernev
2022-09-05 10:02 ` Krzysztof Kozlowski
2022-09-05 10:45 ` Iskren Chernev
2022-09-05 10:54 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 10/14] arm64: dts: qcom: sm6115: Add SPMI bus node Iskren Chernev
2022-09-01 16:14 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 11/14] dt-bindings: arm: cpus: Add kryo240 compatible Iskren Chernev
2022-09-01 15:29 ` Vinod Koul
2022-09-01 16:14 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 12/14] arm64: dts: qcom: sm4250: Add soc dtsi Iskren Chernev
2022-09-01 7:24 ` [PATCH 13/14] dt-bindings: arm: qcom: Add compatible for oneplus,billie2 phone Iskren Chernev
2022-09-01 16:17 ` Krzysztof Kozlowski
2022-09-01 7:24 ` [PATCH 14/14] arm64: dts: qcom: sm4250: Add support for oneplus-billie2 Iskren Chernev
2022-09-01 16:20 ` Krzysztof Kozlowski
2022-09-03 12:32 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=339df7b9-bc7d-039d-99d8-ecdd480419d8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=iskren.chernev@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).