From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F2DC433EF for ; Thu, 9 Dec 2021 09:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229449AbhLIJnx convert rfc822-to-8bit (ORCPT ); Thu, 9 Dec 2021 04:43:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbhLIJnw (ORCPT ); Thu, 9 Dec 2021 04:43:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6079C061746 for ; Thu, 9 Dec 2021 01:40:19 -0800 (PST) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvFuQ-0001Gj-Uo; Thu, 09 Dec 2021 10:40:14 +0100 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1mvFuJ-0004ES-Gu; Thu, 09 Dec 2021 10:40:07 +0100 Message-ID: <33ab37f5b30252e41f3e0769c7702764a9e77d7f.camel@pengutronix.de> Subject: Re: [PATCH v9 3/6] dt-bindings: reset: Add Delta TN48M From: Philipp Zabel To: Robert Marko , Linus Walleij , Bartosz Golaszewski , Rob Herring , Lee Jones , "open list:GPIO SUBSYSTEM" , devicetree , Andy Shevchenko , Michael Walle , Andrew Lunn Cc: Luka Perkov , Bruno Banelli Date: Thu, 09 Dec 2021 10:40:07 +0100 In-Reply-To: References: <20211109113239.93493-1-robert.marko@sartura.hr> <20211109113239.93493-3-robert.marko@sartura.hr> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Robert, On Wed, 2021-12-01 at 22:28 +0100, Robert Marko wrote: > On Tue, Nov 9, 2021 at 12:32 PM Robert Marko wrote: > > > > Add header for the Delta TN48M CPLD provided > > resets. > > > > Signed-off-by: Robert Marko > > --- > >  include/dt-bindings/reset/delta,tn48m-reset.h | 20 +++++++++++++++++++ > >  1 file changed, 20 insertions(+) > >  create mode 100644 include/dt-bindings/reset/delta,tn48m-reset.h > > > > diff --git a/include/dt-bindings/reset/delta,tn48m-reset.h b/include/dt-bindings/reset/delta,tn48m-reset.h > > new file mode 100644 > > index 000000000000..d4e9ed12de3e > > --- /dev/null > > +++ b/include/dt-bindings/reset/delta,tn48m-reset.h > > @@ -0,0 +1,20 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * Delta TN48M CPLD GPIO driver > > + * > > + * Copyright (C) 2021 Sartura Ltd. > > + * > > + * Author: Robert Marko > > + */ > > + > > +#ifndef _DT_BINDINGS_RESET_TN48M_H > > +#define _DT_BINDINGS_RESET_TN48M_H > > + > > +#define CPU_88F7040_RESET 0 > > +#define CPU_88F6820_RESET 1 > > +#define MAC_98DX3265_RESET 2 > > +#define PHY_88E1680_RESET 3 > > +#define PHY_88E1512_RESET 4 > > +#define POE_RESET 5 > > + > > +#endif /* _DT_BINDINGS_RESET_TN48M_H */ > > -- > > 2.33.1 > > > > Does anybody have any comments on the patch as the reset driver got reviewed and > the bindings have not? Not much to review here, I can't tell if the indices are correct. Acked-by: Philipp Zabel To be merged with the rest of the series. Or do you want me to pick up the reset parts individually? In that case you'd have to split out the reset bindings into a separate patch. regards Philipp