From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andrew Halaney <ahalaney@redhat.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@somainline.org, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dianders@chromium.org,
johan@kernel.org
Subject: Re: [PATCH 1/3] regulator: dt-bindings: qcom,rpmh: Use additionalProperties
Date: Mon, 5 Sep 2022 18:45:37 +0200 [thread overview]
Message-ID: <33c19838-2e44-2164-11c7-b14be5908809@linaro.org> (raw)
In-Reply-To: <20220902185148.635292-2-ahalaney@redhat.com>
On 02/09/2022 20:51, Andrew Halaney wrote:
> Right now, running make dt_binding_check results in this snippet:
>
> /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: 'additionalProperties' is a required property
> hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties"
> from schema $id: http://devicetree.org/meta-schemas/base.yaml#
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> <snip..>
> /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: ignoring, error in schema:
>
> Which results in the schema not being properly evaluated. Swap out
> unevaluatedProperties which doesn't seem to be doing anything for
> additionalProperties.
unevaluatedProperties were required due to usage of defs-allOf
(ba5d99609a5e ("regulator: dt-bindings: qcom,rpmh: document supplies per
variant")
).
Are you sure that it works correctly with additionalProperties?
Judging by errors it doesn't....
>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
> .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> index 9a36bee750af..b3fd60b21610 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> @@ -106,6 +106,8 @@ patternProperties:
> $ref: "regulator.yaml#"
> description: smps/ldo regulator nodes(s).
>
> +additionalProperties: false
> +
Don't move the location. The proper one is above examples.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-05 16:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 18:51 [PATCH 0/3] regulator: dt-bindings: qcom,rpmh: dt-binding fixups Andrew Halaney
2022-09-02 18:51 ` [PATCH 1/3] regulator: dt-bindings: qcom,rpmh: Use additionalProperties Andrew Halaney
2022-09-02 21:34 ` Rob Herring
2022-09-05 16:45 ` Krzysztof Kozlowski [this message]
2022-09-05 16:53 ` Krzysztof Kozlowski
2022-09-06 14:32 ` Andrew Halaney
2022-09-02 18:51 ` [PATCH 2/3] regulator: dt-bindings: qcom,rpmh: Specify supply property Andrew Halaney
2022-09-05 16:47 ` Krzysztof Kozlowski
2022-09-02 18:51 ` [PATCH 3/3] regulator: dt-bindings: qcom,rpmh: Indicate regulator-allow-set-load dependencies Andrew Halaney
2022-09-05 16:50 ` Krzysztof Kozlowski
2022-09-06 14:41 ` Andrew Halaney
2022-09-08 10:23 ` Krzysztof Kozlowski
2022-09-06 20:25 ` [PATCH 0/3] regulator: dt-bindings: qcom,rpmh: dt-binding fixups Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c19838-2e44-2164-11c7-b14be5908809@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).