Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Xilin Wu <sophon@radxa.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc8280xp: Add more thermal zones
Date: Fri, 15 May 2026 12:46:59 +0200	[thread overview]
Message-ID: <33d3ba72-7d3c-41a8-bf24-baf325ce823d@oss.qualcomm.com> (raw)
In-Reply-To: <20260507-sc8280xp-thermal-zones-v1-2-33d4395b1be9@radxa.com>

On 5/7/26 4:34 PM, Xilin Wu wrote:
> The SC8280XP contains a lot of TSENS sensors which are not yet described.
> Add the thermal zones for them.
> 
> Signed-off-by: Xilin Wu <sophon@radxa.com>
> ---

Very nice to see, just a couple nits:

tsens0 11 -> NSP1-0
tsens1 11 -> NSP1-2
tsens2 10 -> NSP1-1

cluster0/1-thermal are a little inaccurate, let's rename them to
cpuss0/1 as they are not really bound to either cluster

and please change mem-N -> ddrss-N 

Konrad

      reply	other threads:[~2026-05-15 10:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 14:34 [PATCH 0/2] arm64: dts: qcom: sc8280xp: thermal zones fixes & additions Xilin Wu
2026-05-07 14:34 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp: drop unused polling-delay-passive properties Xilin Wu
2026-05-08  9:42   ` Konrad Dybcio
2026-05-07 14:34 ` [PATCH 2/2] arm64: dts: qcom: sc8280xp: Add more thermal zones Xilin Wu
2026-05-15 10:46   ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33d3ba72-7d3c-41a8-bf24-baf325ce823d@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sophon@radxa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox