From: "Stefan O'Rear" <sorear@fastmail.com>
To: "Palmer Dabbelt" <palmer@rivosinc.com>,
"Conor Dooley" <conor@kernel.org>
Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: RISC-V: Re-word the I extension binding
Date: Tue, 11 Jul 2023 19:28:25 -0400 [thread overview]
Message-ID: <33dd566f-adfc-4148-9bef-362935ddb606@app.fastmail.com> (raw)
In-Reply-To: <20230711225212.11542-1-palmer@rivosinc.com>
On Tue, Jul 11, 2023, at 6:52 PM, Palmer Dabbelt wrote:
> I'd argue this changes the definition of the I binding, as there was
> more than just the counters that got split out (CSRs and fence.i at
> least). We haven't released these bindings yet, so IIUC it's OK to
> change the definition still.
>
> I think this matches the original intent, or at least what the
> implementation does.
>
> Fixes: aeb71e42caae ("dt-bindings: riscv: deprecate riscv,isa")
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> .../devicetree/bindings/riscv/extensions.yaml | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml
> b/Documentation/devicetree/bindings/riscv/extensions.yaml
> index cc1f546fdbdc..31ec244bd32f 100644
> --- a/Documentation/devicetree/bindings/riscv/extensions.yaml
> +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml
> @@ -67,13 +67,11 @@ properties:
> anyOf:
> # single letter extensions, in canonical order
> - const: i
> - description: |
> - The base integer instruction set, as ratified in the
> 20191213
> - version of the unprivileged ISA specification.
> -
> - This does not include Chapter 10, "Counters", which was
> moved into
> - the Zicntr and Zihpm extensions after the ratification of
> the
> - 20191213 version of the unprivileged specification.
> + description:
> + The base integer instruction set, as specified by the 2.2
> + version of the unprivileged ISA specification, formally
> known as
> + the user-level ISA. This definition of I includes various
> + extensions that were later split out.
Nitpick: the 2.2 unprivileged ISA uses the pre-ratification memory model
(essentially Alpha), which is much weaker than the memory model in 20191213.
-s
>
> - const: m
> description:
> --
> 2.40.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-11 23:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 22:52 [PATCH] dt-bindings: RISC-V: Re-word the I extension binding Palmer Dabbelt
2023-07-11 23:28 ` Stefan O'Rear [this message]
2023-07-12 15:04 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33dd566f-adfc-4148-9bef-362935ddb606@app.fastmail.com \
--to=sorear@fastmail.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).