From: Krzysztof Kozlowski <krzk@kernel.org>
To: CL Wang <cl634@andestech.com>,
broonie@kernel.org, linux-spi@vger.kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
tim609@andestech.com
Subject: Re: [PATCH V2 1/3] dt-bindings: spi: Add support for ATCSPI200 SPI controller
Date: Thu, 11 Dec 2025 06:31:23 +0100 [thread overview]
Message-ID: <33e24f43-53d3-46cf-9012-aed67230723b@kernel.org> (raw)
In-Reply-To: <20251210090430.3602380-2-cl634@andestech.com>
On 10/12/2025 10:04, CL Wang wrote:
> Document devicetree bindings for the Andes ATCSPI200 SPI controller.
>
> Signed-off-by: CL Wang <cl634@andestech.com>
> - Dropped the "spi_" prefix from dma-names as suggested.
> - Updated the DT binding and documented all compatible strings.
> - Added the "andestech,ae350-spi" compatible string.
>
> AE350 is part of the AndeShape™ platform family and is a commercially
> supported product with a fixed, documented SoC-level architecture (memory
> map, interrupt topology, and peripheral integration). Although AE350 is
> often deployed on FPGA boards, the platform behaves as a stable SoC
> integration rather than a prototype.
>
> Upstream Linux already accepts FPGA-based platform-level compatible strings
> for stable SoC-like integrations. For example, the Tensilica FPGA platform
> uses:
> compatible = "cdns,xtfpga-spi";
>
> Following the same rationale, "andestech,ae350-spi" is proposed as the
> platform-level compatible string for AE350-based devices.
>
> More information about AE350 can be found at:
> https://www.andestech.com/en/products-solutions/andeshape-platforms/ae350-axi-based-platform-pre-integrated-with-n25f-nx25f-a25-ax25/
>
That's a completely corrupted changelog.
Please apply your patch and look. Or run checkpatch. Does it look good?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-11 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 9:04 [PATCH V2 0/3] spi: atcspi200: Add support for Andes ATCSPI200 SPI controller CL Wang
2025-12-10 9:04 ` [PATCH V2 1/3] dt-bindings: spi: Add support for " CL Wang
2025-12-10 18:36 ` Conor Dooley
2025-12-12 9:33 ` CL Wang
2025-12-11 5:31 ` Krzysztof Kozlowski [this message]
2025-12-12 9:49 ` CL Wang
2025-12-10 9:04 ` [PATCH V2 2/3] spi: atcspi200: Add ATCSPI200 SPI controller driver CL Wang
2025-12-10 9:04 ` [PATCH V2 3/3] MAINTAINERS: Add MAINTAINERS entry for the " CL Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33e24f43-53d3-46cf-9012-aed67230723b@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=cl634@andestech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tim609@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).