From: Andrew Davis <afd@ti.com>
To: Vaishnav Achath <vaishnav.a@ti.com>, <vigneshr@ti.com>,
<nm@ti.com>, <kristo@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
<u-kumar1@ti.com>
Subject: Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller
Date: Thu, 19 Oct 2023 16:05:08 -0500 [thread overview]
Message-ID: <33e958fb-71b9-43b2-911c-a187651a0de4@ti.com> (raw)
In-Reply-To: <20231009082452.30684-2-vaishnav.a@ti.com>
On 10/9/23 3:24 AM, Vaishnav Achath wrote:
> From: Nishanth Menon <nm@ti.com>
>
> Use ti,j721e-system-controller to be explicit about the syscon node we
> are using.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
>
> No changes since V1.
>
> arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> index 6ffaf85fa63f..2ee6215e38a6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> @@ -165,7 +165,7 @@
> };
>
> mcu_conf: syscon@40f00000 {
> - compatible = "syscon", "simple-mfd";
> + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
There is already a "ti,j721e-system-controller" in the main domain dtsi. And this
is not one of those. You are hiding a valid DT warning by adding an incorrect
compatible string that just so happens to not throw the warning.
This should be a "simple-bus" node.
Andrew
> reg = <0x00 0x40f00000 0x00 0x20000>;
> #address-cells = <1>;
> #size-cells = <1>;
next prev parent reply other threads:[~2023-10-19 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 8:24 [PATCH v4 0/2] arm64: dts: ti: k3-j7200: Fixes for various dtbs_checks warnings Vaishnav Achath
2023-10-09 8:24 ` [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller Vaishnav Achath
2023-10-19 19:13 ` reidt
2023-10-19 21:05 ` Andrew Davis [this message]
2023-10-09 8:24 ` [PATCH v4 2/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux Vaishnav Achath
2023-10-19 19:15 ` reidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33e958fb-71b9-43b2-911c-a187651a0de4@ti.com \
--to=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).