From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yassine Oudjana <yassine.oudjana@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Yassine Oudjana <y.oudjana@protonmail.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: display: mediatek: Compatible list cleanup
Date: Thu, 2 Mar 2023 14:53:36 +0100 [thread overview]
Message-ID: <33edb557-f5c6-6ce1-2914-bcab2eca23c3@linaro.org> (raw)
In-Reply-To: <20230302133528.124113-1-y.oudjana@protonmail.com>
On 02/03/2023 14:35, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
>
> Several DT bindings of MediaTek display blocks make unnecessary use of
> "oneOf" and "items", and have some enums with only 1 element. Remove
> unnecessary "oneOf" and "items", and replace enums that have 1 element
> with "const".
>
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
> .../bindings/display/mediatek/mediatek,aal.yaml | 3 +--
> .../display/mediatek/mediatek,ccorr.yaml | 10 ++++------
> .../display/mediatek/mediatek,color.yaml | 10 ++++------
> .../display/mediatek/mediatek,dither.yaml | 3 +--
> .../bindings/display/mediatek/mediatek,dsc.yaml | 4 +---
> .../display/mediatek/mediatek,gamma.yaml | 7 +++----
> .../display/mediatek/mediatek,merge.yaml | 8 +++-----
> .../bindings/display/mediatek/mediatek,od.yaml | 8 +++-----
> .../display/mediatek/mediatek,ovl-2l.yaml | 10 ++++------
> .../bindings/display/mediatek/mediatek,ovl.yaml | 16 ++++++----------
> .../display/mediatek/mediatek,postmask.yaml | 3 +--
> .../bindings/display/mediatek/mediatek,rdma.yaml | 13 +++++--------
> .../display/mediatek/mediatek,split.yaml | 4 +---
> .../bindings/display/mediatek/mediatek,ufoe.yaml | 4 +---
> .../bindings/display/mediatek/mediatek,wdma.yaml | 4 +---
> 15 files changed, 39 insertions(+), 68 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> index 92741486c24d..d8d78abd6c6c 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
> @@ -25,8 +25,7 @@ properties:
> - mediatek,mt8173-disp-aal
> - mediatek,mt8183-disp-aal
> - items:
> - - enum:
> - - mediatek,mt2712-disp-aal
> + - const: mediatek,mt2712-disp-aal
This was I think intentional - it will grow. The same in all other
one-enum cases, it might be unnecessary change which soon will be
reverted converting back to enum.
> - const: mediatek,mt8173-disp-aal
> - items:
> - enum:
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> index b04820c95b22..e72d2884bb49 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml
> @@ -21,18 +21,16 @@ description: |
> properties:
> compatible:
> oneOf:
> - - items:
> - - const: mediatek,mt8183-disp-ccorr
> - - items:
> - - const: mediatek,mt8192-disp-ccorr
> + - enum:
> + - mediatek,mt8183-disp-ccorr
> + - mediatek,mt8192-disp-ccorr
Such changes are fine.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-02 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 13:35 [PATCH] dt-bindings: display: mediatek: Compatible list cleanup Yassine Oudjana
2023-03-02 13:53 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33edb557-f5c6-6ce1-2914-bcab2eca23c3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=y.oudjana@protonmail.com \
--cc=yassine.oudjana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).