From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Unnathi Chalicheemala <quic_uchalich@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v3 4/5] arm64: dts: qcom: sm8550: Add mapping to llcc Broadcast_AND region
Date: Sat, 2 Mar 2024 01:09:43 +0100 [thread overview]
Message-ID: <33f40e44-fbfe-42d2-aa23-f77529ee904e@linaro.org> (raw)
In-Reply-To: <65e9ef21-3406-4632-a607-2c4e9d587131@quicinc.com>
On 28.02.2024 02:17, Unnathi Chalicheemala wrote:
> On 2/27/2024 7:49 AM, Krzysztof Kozlowski wrote:
>> On 23/02/2024 00:07, Unnathi Chalicheemala wrote:
>>> Mapping Broadcast_AND region for LLCC in SM8550.
"Map" would be grammatically connect here
>>
>> I don't understand this sentence and I still do not know why.
>>
>
> The check of whether status bit is 1 in the driver is being done
> with the wrong register all along (sm8450 onwards). So I am adding
> the base address of the right register region in the DeviceTree files.
>
> I can add this explanation to the commit message of these
> patches if you think that would help.
Yes, the commit message should definitely state the problem, and if
not obvious, the reason for the solution.
Paraphrasing Greg KH (I think?), the maintainers are going to assume
your patch is unnecessary and your job is to convince them that it's
not the case. You do it through good code and meaningful commit titles&
messages.
Please refer to [1].
Konrad
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
prev parent reply other threads:[~2024-03-02 0:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 23:07 [PATCH v3 0/5] LLCC: Support for Broadcast_AND region Unnathi Chalicheemala
2024-02-22 23:07 ` [PATCH v3 1/5] dt-bindings: arm: msm: Add llcc Broadcast_AND register Unnathi Chalicheemala
2024-02-27 15:47 ` Krzysztof Kozlowski
2024-02-28 1:04 ` Unnathi Chalicheemala
2024-02-28 7:14 ` Krzysztof Kozlowski
2024-02-28 17:54 ` Unnathi Chalicheemala
2024-02-22 23:07 ` [PATCH v3 2/5] soc: qcom: llcc: Add regmap for Broadcast_AND region Unnathi Chalicheemala
2024-03-12 1:05 ` Konrad Dybcio
2024-02-22 23:07 ` [PATCH v3 3/5] arm64: dts: qcom: sm8450: Add mapping to llcc " Unnathi Chalicheemala
2024-02-27 15:48 ` Krzysztof Kozlowski
2024-02-22 23:07 ` [PATCH v3 4/5] arm64: dts: qcom: sm8550: " Unnathi Chalicheemala
2024-02-27 15:49 ` Krzysztof Kozlowski
2024-02-28 1:17 ` Unnathi Chalicheemala
2024-03-02 0:09 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f40e44-fbfe-42d2-aa23-f77529ee904e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_uchalich@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).