From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vadym Kochan <vadym.kochan@plvision.eu>,
Hu Ziji <huziji@marvell.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Elad Nachman <enachman@marvell.com>
Subject: Re: [PATCH 1/3] dt-bindings: mmc: xenon: Add compatible string for Xenon SDHCI on AC5 SoC
Date: Mon, 8 Aug 2022 12:18:51 +0300 [thread overview]
Message-ID: <33f5b621-af3b-b6a2-5e3d-c01fe40eb5be@linaro.org> (raw)
In-Reply-To: <20220806085818.9873-2-vadym.kochan@plvision.eu>
On 06/08/2022 11:58, Vadym Kochan wrote:
> It indicates the Xenon SDHCI on AC5 SoC so the driver will try to fixup
> the 2G address space limitation issue.
>
> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
> ---
> Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> index 3ee758886558..17cda847e0a3 100644
> --- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> @@ -34,6 +34,9 @@ properties:
> - const: marvell,armada-3700-sdhci
> - const: marvell,sdhci-xenon
>
> + - items:
> + - const: marvell,ac5-sdhci
These are not items. Should be part of existing enum.
You missed updating allOf:if:then.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-08 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 8:58 [PATCH 0/3] mmc: xenon-sdhci: Try to fix 2G address limitation on AC5 SoC Vadym Kochan
2022-08-06 8:58 ` [PATCH 1/3] dt-bindings: mmc: xenon: Add compatible string for Xenon SDHCI " Vadym Kochan
2022-08-08 9:18 ` Krzysztof Kozlowski [this message]
2022-08-06 8:58 ` [PATCH 2/3] mmc: sdhci-xenon: Try to fix 2G address limitation " Vadym Kochan
2022-08-08 9:20 ` Krzysztof Kozlowski
2022-08-06 8:58 ` [PATCH 3/3] arm64: dts: marvell: Add DTSI to fix Xenon SDHCI 2G " Vadym Kochan
2022-08-08 9:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f5b621-af3b-b6a2-5e3d-c01fe40eb5be@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=enachman@marvell.com \
--cc=huziji@marvell.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vadym.kochan@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).