From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
"Joe.C" <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Mark Rutland <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Sricharan R <r.sricharan-l0cyMroinI0@public.gmane.org>,
Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"yingjoe.chen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<yingjoe.chen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org"
<yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
"arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"nathan.chung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org"
<nathan.chung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
"grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Marc Carino <marc.ceeeee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org"
<eddie.huang@me>
Subject: Re: [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain.
Date: Thu, 09 Oct 2014 19:22:29 +0200 [thread overview]
Message-ID: <3400038.iFbzPVHU3g@wuerfel> (raw)
In-Reply-To: <5436BF0C.1030508-5wv7dgnIgG8@public.gmane.org>
On Thursday 09 October 2014 17:59:56 Marc Zyngier wrote:
> > @@ -952,7 +988,11 @@ void __init gic_init_bases(unsigned int gic_nr, int irq_start,
> >
> > gic_irqs -= hwirq_base; /* calculate # of irqs to allocate */
> >
> > - if (of_property_read_u32(node, "arm,routable-irqs",
> > + if (IS_ENABLED(CONFIG_IRQ_DOMAIN_HIERARCHY) &&
> > + of_find_property(node, "arm,irq-domain-hierarchy", NULL))
> > + gic->domain = irq_domain_add_linear(node, gic_irqs,
> > + &gic_irq_domain_hierarchy_ops, gic);
>
> I really think that looking for a property is the wrong thing to do. If
> "node" is non-NULL, then we're pretty sure that we're initializing from
> DT, and that a pure linear domain should be the right thing, leaving the
> legacy stuff for the few non-DT platforms that are still around.
FWIW, these are the remaining ones that use gic:
arch/arm/mach-cns3xxx/core.c: gic_init(0, 29, IOMEM(CNS3XXX_TC11MP_GIC_DIST_BASE_VIRT),
arch/arm/mach-realview/realview_eb.c: gic_init(0, 29, __io_address(REALVIEW_EB11MP_GIC_DIST_BASE),
arch/arm/mach-realview/realview_eb.c: gic_init(1, 96, __io_address(REALVIEW_EB_GIC_DIST_BASE),
arch/arm/mach-realview/realview_eb.c: gic_init(0, 29, __io_address(REALVIEW_EB_GIC_DIST_BASE),
arch/arm/mach-realview/realview_pb1176.c: gic_init(0, IRQ_DC1176_GIC_START,
arch/arm/mach-realview/realview_pb1176.c: gic_init(1, IRQ_PB1176_GIC_START,
arch/arm/mach-realview/realview_pb11mp.c: gic_init(0, 29, __io_address(REALVIEW_TC11MP_GIC_DIST_BASE),
arch/arm/mach-realview/realview_pb11mp.c: gic_init(1, IRQ_PB11MP_GIC_START,
arch/arm/mach-realview/realview_pba8.c: gic_init(0, IRQ_PBA8_GIC_START,
arch/arm/mach-realview/realview_pbx.c: gic_init(0, 29, __io_address(REALVIEW_PBX_TILE_GIC_DIST_BASE),
arch/arm/mach-realview/realview_pbx.c: gic_init(0, IRQ_PBX_GIC_START,
arch/arm/mach-shmobile/intc-sh73a0.c: gic_init(0, 29, gic_dist_base, gic_cpu_base);
arch/arm/mach-tegra/irq.c: gic_init(0, 29, distbase,
arch/arm/mach-vexpress/ct-ca9x4.c: gic_init(0, 29, ioremap(A9_MPCORE_GIC_DIST, SZ_4K),
Linus Walleij is working on realview, Pawel already has a patch for vexpress, the tegra one
can just be removed and the Renesas team will deal with shmobile.
This basically leaves cns3xxx, which now has a new maintainer but I suspect we won't
have DT-only support for it too soon anyway.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-09 17:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 14:29 [PATCH v3 0/7] ARM: mediatek: Add support for interrupt polarity Joe.C
2014-10-09 14:29 ` [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check Joe.C
2014-10-13 12:11 ` Marc Zyngier
[not found] ` <543BC186.2050701-5wv7dgnIgG8@public.gmane.org>
2014-10-13 14:13 ` Jiang Liu
2014-10-09 14:29 ` [PATCH v3 2/7] genirq: Add more helper functions to support stacked irq_chip Joe.C
2014-10-09 14:29 ` [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain Joe.C
2014-10-09 16:59 ` Marc Zyngier
[not found] ` <5436BF0C.1030508-5wv7dgnIgG8@public.gmane.org>
2014-10-09 17:22 ` Arnd Bergmann [this message]
2014-10-13 10:43 ` Joe.C
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 8:56 ` Marc Zyngier
[not found] ` <543B93B4.3040404-5wv7dgnIgG8@public.gmane.org>
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:27 ` Arnd Bergmann
2014-10-13 9:44 ` Marc Zyngier
2014-10-09 14:29 ` [PATCH v3 4/7] ARM: mediatek: Add sysirq interrupt polarity support Joe.C
2014-10-09 14:37 ` Arnd Bergmann
2014-10-09 14:53 ` Joe.C
2014-10-13 13:43 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
2014-10-09 14:29 ` [PATCH v3 5/7] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi Joe.C
2014-10-09 14:29 ` [PATCH v3 6/7] dt-bindings: add irq domain parent binding Joe.C
[not found] ` <1412864980-20273-7-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2014-10-09 14:57 ` Mark Rutland
2014-10-09 14:29 ` [PATCH v3 7/7] dt-bindings: add bindings for mediatek sysirq Joe.C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3400038.iFbzPVHU3g@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=Mark.Rutland-5wv7dgnIgG8@public.gmane.org \
--cc=Pawel.Moll-5wv7dgnIgG8@public.gmane.org \
--cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eddie.huang@me \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=marc.ceeeee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=nathan.chung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=r.sricharan-l0cyMroinI0@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=yingjoe.chen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox